Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D11 backend appears to hard-depend on SDL in code, but not in build system #360

Open
rpavlik opened this issue Dec 21, 2017 · 1 comment

Comments

@rpavlik
Copy link
Member

rpavlik commented Dec 21, 2017

RenderManagerD3D.h includes SDL.h (for a pointer), and forward-declaring the pointer type doesn't let you build without that include. However, the build system appears to explicitly distinguish between building D3D backend with SDL2 and without SDL2, implying you can actually build without SDL2.

If we can't build the D3D backend without SDL2, then the build system should change so that the requirement for SDL2 is made explicit (rather than becoming a build-time include error). If we should be able to build without SDL2, then there is some code that needs changing.

@russell-taylor
Copy link
Contributor

Related to #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants