Fixed Exceptions check logic #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only force `std::abort()` over `throw` if `__cpp_exceptions` is disabled rather than enabled.
muggenhor
reviewed
Jul 27, 2023
| @@ -23,7 +23,7 @@ | |||
| #ifndef FROZEN_LETITGO_EXCEPTIONS_H | |||
| #define FROZEN_LETITGO_EXCEPTIONS_H | |||
|
|
|||
| #if defined(FROZEN_NO_EXCEPTIONS) || (defined(_MSC_VER) && !defined(_CPPUNWIND)) || (defined(__cpp_exceptions) && __cpp_exceptions) | |||
| #if defined(FROZEN_NO_EXCEPTIONS) || (defined(_MSC_VER) && !defined(_CPPUNWIND)) || (defined(__cpp_exceptions) && !__cpp_exceptions) | |||
There was a problem hiding this comment.
You may as well skip the defined test:
Suggested change
| #if defined(FROZEN_NO_EXCEPTIONS) || (defined(_MSC_VER) && !defined(_CPPUNWIND)) || (defined(__cpp_exceptions) && !__cpp_exceptions) | |
| #if defined(FROZEN_NO_EXCEPTIONS) || (defined(_MSC_VER) && !defined(_CPPUNWIND)) || !__cpp_exceptions |
Because inside #if preprocessor conditionals undefined names are always implicitly interpreted as 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::abort()overthrowif__cpp_exceptionsis disabled rather than enabled.