From 426af3d261661e1e3a8a3a814c4ec7034487422b Mon Sep 17 00:00:00 2001 From: sergeykhbr Date: Thu, 15 Jun 2023 15:24:54 +0300 Subject: [PATCH] [!] Fix critical bug: array index out of range in axi2apb_bus1 module. Bug leads to stack corruption was not reported by ncsim --- sv/rtl/ambalib/axi2apb_bus1.sv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sv/rtl/ambalib/axi2apb_bus1.sv b/sv/rtl/ambalib/axi2apb_bus1.sv index 9d33bd0f7..3fb8b277d 100644 --- a/sv/rtl/ambalib/axi2apb_bus1.sv +++ b/sv/rtl/ambalib/axi2apb_bus1.sv @@ -75,11 +75,11 @@ always_comb begin: comb_proc axi2apb_bus1_registers v; int iselidx; - apb_in_type vapbi[0: CFG_BUS1_PSLV_TOTAL-1]; + apb_in_type vapbi[0: (CFG_BUS1_PSLV_TOTAL + 1)-1]; apb_out_type vapbo[0: (CFG_BUS1_PSLV_TOTAL + 1)-1]; iselidx = 0; - for (int i = 0; i < CFG_BUS1_PSLV_TOTAL; i++) begin + for (int i = 0; i < (CFG_BUS1_PSLV_TOTAL + 1); i++) begin vapbi[i] = apb_in_none; end for (int i = 0; i < (CFG_BUS1_PSLV_TOTAL + 1); i++) begin