-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom s6 services dependencies no longer works #479
Comments
Crap. I never thought of people relying on the S6 dependency for their own scripts. What changedIn this PR, we removed the complexity of the S6 overlay process and went complete with a "entrypoint.d" process. This means we did not need the To update your scriptsEverything should work if you put it in My questionDoes this satisfy both of your needs? Or is your use case highly specific where it needs to be managed by S6? |
@jaydrogers I don’t think that it will work. I tried it initially, but since I need to start a long-running application (like amqproxy or pgbouncer), it doesn’t function properly with entrypoint.d scripts. It needs to be set up as an s6 service, similar to how nginx is configured |
Same issues after upgrading to the latest release.
Is there an easy way to load S6 even when a command is specified? |
Can you share your use case? Right now, if you pass the CMD of Before it would run |
@LorenzoRogai: Have you attempted to write your own S6 service and add that to your image? https://github.com/just-containers/s6-overlay?tab=readme-ov-file#writing-a-service-script Then we don't need to rely on this old script which was kind of a hack to take |
I added documentation on why you don't want to use entrypoint services to run long-running services: https://serversideup.net/open-source/docker-php/docs/customizing-the-image/adding-your-own-start-up-scripts#long-running-services I am closing this for now, but please comment below if you have any further questions 👍 |
@jaydrogers If I understand correctly, you were previously using s6 to launch "oneshot" commands, but you've since removed this, which is fine. As I mentioned in the original issue, I've already created a custom s6 service. However, it seems that the custom service can no longer find the 50-laravel-automation dependency because 50-laravel-automation is no longer an s6 "oneshot" command. How can I maintain the same startup order now that 50-laravel-automation is no longer part of s6? |
Just letting you know that I am circling back to this. I think I am going to bring this script back. Will keep you posted once I have more time to look at this 😃 |
Steps To Reproduce
Image: 8.3-fpm-nginx-alpine
In the latest version i can no longer define custom s6 services depending on like 50-laravel-automations - it was working fine with the 2 months ago image
This is the copy definition inside the Dockerfile
It seems that the folder "/etc/s6-overlay/s6-rc.d" no longer contains 50-laravel-automations etc files so when the container starts S6 gives a "50-laravel-automations dependency not found" error
How can i achieve the same flow on the latest build?
Outcome
What did you expect?
What happened instead?
Affected Docker Images
serversideup/php:8.3-fpm-nginx-alpine
Anything else?
No response
The text was updated successfully, but these errors were encountered: