From c07311d936ac3efb3640a2300d74b3ac1421fe67 Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Wed, 15 May 2024 14:29:21 -0700 Subject: [PATCH] fix(chromeos): Fix session manager timing (#91) It seems as if the short sleep time when monitoring the launch of session manager is no longer working correctly, with errors thrown inconsistently during test runs. Using a longer sleep time and fewer loops seems to fix it. --- backends/chromeos/scripts/launch_page.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/backends/chromeos/scripts/launch_page.sh b/backends/chromeos/scripts/launch_page.sh index 5bb184f..32b4429 100644 --- a/backends/chromeos/scripts/launch_page.sh +++ b/backends/chromeos/scripts/launch_page.sh @@ -43,15 +43,14 @@ WRAPPER_ARG="--chrome-command=$WRAPPER_PATH --extra-args=$EXTRA_ARGS_FILE" nohup /sbin/session_manager "$WRAPPER_ARG" /dev/null & # If it's still running after 5 seconds, assume it's going to keep running. -# This loop has an effective timeout of 5 seconds. -for ((i = 0; i < 50; ++i)); do +for ((i = 0; i < 5; ++i)); do if ! pidof session_manager &>/dev/null; then # pidof failed, meaning session_manager is no longer running. # Complain and fail the script. echo "* Failed to launch session manager!" exit 1 fi - sleep 0.1 + sleep 1 done echo "* Launched!"