-
Notifications
You must be signed in to change notification settings - Fork 65
Comparing changes
Open a pull request
base repository: share/sharedb-mongo
base: v2.1.0
head repository: share/sharedb-mongo
compare: master
Commits on Feb 28, 2023
-
💥 BREAKING: drop
mongodb@2
supportThe `mongodb@2` driver is not compatible with MongoDB v6. In order to add support for the latest database, we drop support for this old version of the `mongodb` driver.
Configuration menu - View commit details
-
Copy full SHA for 023f2b2 - Browse repository at this point
Copy the full SHA 023f2b2View commit details -
✅ Add
async
todevDependencies
We incorrectly [removed `async`][1] from our dependencies, but we still import this library for our tests. This change puts it back in our `devDependencies` [1]: https://github.com/share/sharedb-mongo/pull/140/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L7
Configuration menu - View commit details
-
Copy full SHA for eda5a69 - Browse repository at this point
Copy the full SHA eda5a69View commit details -
Merge pull request #144 from share/async-test
✅ Add `async` to `devDependencies`
Configuration menu - View commit details
-
Copy full SHA for 5682d86 - Browse repository at this point
Copy the full SHA 5682d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05c7bae - Browse repository at this point
Copy the full SHA 05c7baeView commit details -
Merge pull request #142 from share/drop-mongodb2
💥 BREAKING: drop `mongodb@2` support
Configuration menu - View commit details
-
Copy full SHA for a2ab6d4 - Browse repository at this point
Copy the full SHA a2ab6d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5575e9 - Browse repository at this point
Copy the full SHA f5575e9View commit details -
Merge pull request #139 from share/mongodb6
⬆️ Add MongoDB server 6 to our test matrix
Configuration menu - View commit details
-
Copy full SHA for 75ab33c - Browse repository at this point
Copy the full SHA 75ab33cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e90c0 - Browse repository at this point
Copy the full SHA 97e90c0View commit details -
This is broken in a fresh install: ``` npm install npm test ``` This is because `npm` will fetch `mongodb@5` (the latest it can), but running `npm test` without the `_SHAREDB_MONGODB_DRIVER` variable set means that the map reduce test still runs, when `mongodb@5` doesn't support it. This change tweaks the test to check if the function is defined, instead of relying on the environment variable.
Configuration menu - View commit details
-
Copy full SHA for adaf37f - Browse repository at this point
Copy the full SHA adaf37fView commit details
Commits on Mar 1, 2023
-
Merge pull request #145 from share/fix-map-reduce-test
✅ Fix `npm test`
Configuration menu - View commit details
-
Copy full SHA for 1bb27de - Browse repository at this point
Copy the full SHA 1bb27deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b7dda - Browse repository at this point
Copy the full SHA 39b7ddaView commit details
Commits on Apr 21, 2023
-
💥 Drop Node.js 14 and add Node.js 20
According to the Node.js [release schedule][1]: - v14 will be end-of-lifed on 30 April - v20 has been released This change drops v14 from our test matrix, and adds v20. [1]: https://nodejs.dev/en/about/releases/
Configuration menu - View commit details
-
Copy full SHA for 73d9a26 - Browse repository at this point
Copy the full SHA 73d9a26View commit details
Commits on Apr 25, 2023
-
Merge pull request #148 from share/bump-node
💥 Drop Node.js 14 and add Node.js 20
Configuration menu - View commit details
-
Copy full SHA for 83dd2d2 - Browse repository at this point
Copy the full SHA 83dd2d2View commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3bf44aa - Browse repository at this point
Copy the full SHA 3bf44aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c91afc - Browse repository at this point
Copy the full SHA 9c91afcView commit details -
Merge pull request #149 from share/sharedb-4
Add support for sharedb@4
Configuration menu - View commit details
-
Copy full SHA for e5a01cf - Browse repository at this point
Copy the full SHA e5a01cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b38af - Browse repository at this point
Copy the full SHA a9b38afView commit details
Commits on Aug 29, 2023
-
This change adds support for the latest major version bump of the `mongodb` driver: [v6][1]. None of the breaks appear to affect us, so we just update our `dependencies` and test matrix. [1]: https://github.com/mongodb/node-mongodb-native/releases/tag/v6.0.0
Configuration menu - View commit details
-
Copy full SHA for ec898a4 - Browse repository at this point
Copy the full SHA ec898a4View commit details
Commits on Sep 6, 2023
-
Merge pull request #151 from share/mongodb6
⬆️ Add support for `mongodb@6`
Configuration menu - View commit details
-
Copy full SHA for b72c420 - Browse repository at this point
Copy the full SHA b72c420View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca1235 - Browse repository at this point
Copy the full SHA 0ca1235View commit details
Commits on Feb 13, 2024
-
Add dev dependency on rich-text for tests
sharedb-mongo includes and runs all tests from sharedb core, and one of the core tests requires rich-text to be installed.
Configuration menu - View commit details
-
Copy full SHA for 8270f4a - Browse repository at this point
Copy the full SHA 8270f4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b54863a - Browse repository at this point
Copy the full SHA b54863aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 220dfbf - Browse repository at this point
Copy the full SHA 220dfbfView commit details -
Merge pull request #154 from share/fix-map-add-tests
Fix $map query transform, add tests for $map and $explain
Configuration menu - View commit details
-
Copy full SHA for 5e6fc4c - Browse repository at this point
Copy the full SHA 5e6fc4cView commit details -
Resolve memory leak when using cursor operations like $count in mongo…
…db@4-6 Starting in Mongo Node driver `mongodb@4`, up through the latest version `mongodb@6`, using `cursor.count()` results in a memory leak. `mongodb@3` doesn't leak in the same situation. The driver creates an implicit client session, but it doesn't automatically close the session when getting the results back from the server. Those unclosed sessions build up over time, causing a memory leak. sharedb-mongo exposes document counting via a user passing the `$count: true` property on query objects, and it currently uses `cursor.count()`. There are a couple ways sharedb-mongo could address the leak: - Switch to `Collection#countDocuments()`, which is the recommended replacement for the deprecated `FindCursor#count()`. This is better long-term, but it's more work since we have to map things like `$limit` from using chained cursor calls over to the equivalent property in CountOptions, where appropriate. - Explicitly close the cursor. Easy and safe, since the cursor is created inside sharedb-mongo and not exposed externally. To resolve the leak more quickly, this change opts for the latter, explicitly closing the cursor for the "cursor operations" `$count`, `$explain`, and `$map`.
Configuration menu - View commit details
-
Copy full SHA for 06b5c78 - Browse repository at this point
Copy the full SHA 06b5c78View commit details -
Remove cursor.close() for $map since it now calls toArray(), making t…
…he close() unnecessary
Configuration menu - View commit details
-
Copy full SHA for 3410c26 - Browse repository at this point
Copy the full SHA 3410c26View commit details -
Merge pull request #152 from share/fix-mongo-count-leak
Resolve memory leak when using cursor operations like $count in mongodb@4-6
Configuration menu - View commit details
-
Copy full SHA for 2b3566d - Browse repository at this point
Copy the full SHA 2b3566dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98563df - Browse repository at this point
Copy the full SHA 98563dfView commit details
Commits on Apr 15, 2024
-
👷♀️ Update MongoDB test matrix
According to the MongoDB [release schedule][1]: - MongoDB 4.2 is EoL this month (April 2023) - MongoDB 7.0 was released in August [1]: https://www.mongodb.com/legal/support-policy/lifecycles
Configuration menu - View commit details
-
Copy full SHA for e6df010 - Browse repository at this point
Copy the full SHA e6df010View commit details
Commits on Apr 16, 2024
-
Merge pull request #155 from share/update-mongodb-matrix
👷♀️ Update MongoDB test matrix
Configuration menu - View commit details
-
Copy full SHA for 0013d15 - Browse repository at this point
Copy the full SHA 0013d15View commit details
Commits on May 15, 2024
-
👷♀️ Update Node.js build matrix
Drop Node.js v16 support, and add v22 support in-line with the Node.js [release schedule][1]. [1]: https://github.com/nodejs/release#release-schedule
Configuration menu - View commit details
-
Copy full SHA for 95e5398 - Browse repository at this point
Copy the full SHA 95e5398View commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d4e40e - Browse repository at this point
Copy the full SHA 9d4e40eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e88b0a - Browse repository at this point
Copy the full SHA 7e88b0aView commit details
Commits on May 20, 2024
-
🔧 Allow disabling the
src
/seq
/v
index- Fixes #94 - Follows on from share/sharedb#657 This change is to work alongside upstream work to remove ShareDB's usage of `getCommittedOpVersion()`. In `sharedb-mongo` this function requires an entire extra op index, just to handle a corner case where two `create` ops are submitted at the same time, which should happen relatively infrequently. This change allows consumers to opt out of individual indexes. For example, if we're not using `getCommittedOpVersion()`, consumers can opt out of the automatic `src`/`seq`/`v` index creation with: ```js new ShareDbMongo( mongoUrl, { disableIndexCreation: { src_seq_v: true, }, }, ); ``` Note that if this index already exists, consumers will need to manually remove it. Previous behaviour will still work, so setting: ```js new ShareDbMongo( mongoUrl, { disableIndexCreation: true, }, ); ``` disables **all** index creation.
Configuration menu - View commit details
-
Copy full SHA for 763baa6 - Browse repository at this point
Copy the full SHA 763baa6View commit details
Commits on May 28, 2024
-
Merge pull request #157 from share/no-src-seq-index
🔧 Allow disabling the `src`/`seq`/`v` index
Configuration menu - View commit details
-
Copy full SHA for 162b81c - Browse repository at this point
Copy the full SHA 162b81cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d48f2c7 - Browse repository at this point
Copy the full SHA d48f2c7View commit details
Commits on Jun 12, 2024
-
Merge pull request #156 from share/nodejs-matrix
👷♀️ Update Node.js build matrix
Configuration menu - View commit details
-
Copy full SHA for 6ce36de - Browse repository at this point
Copy the full SHA 6ce36deView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc887c7 - Browse repository at this point
Copy the full SHA dc887c7View commit details -
Sometimes this test fails with: ``` 1) mongo db connection via url string with mongoPoll and pollDelay option delays queryPoll but not commit: Uncaught AssertionError: expected 1000 to be above 1000 + expected - actual at /home/runner/work/sharedb-mongo/sharedb-mongo/test/test_mongo.js:541:48 at /home/runner/work/sharedb-mongo/sharedb-mongo/index.js:133:2086 at /home/runner/work/sharedb-mongo/sharedb-mongo/index.js:133:109 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ``` We don't care about the exact millisecond, so this change updates the assertion to `greaterThanOrEqual()`
Configuration menu - View commit details
-
Copy full SHA for 3470ec5 - Browse repository at this point
Copy the full SHA 3470ec5View commit details -
Will check for updates to Github Actions.
Configuration menu - View commit details
-
Copy full SHA for 56143f4 - Browse repository at this point
Copy the full SHA 56143f4View commit details -
Bump actions/setup-node from 3 to 4
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 39deb83 - Browse repository at this point
Copy the full SHA 39deb83View commit details -
Merge pull request #161 from share/dependabot/github_actions/actions/…
…setup-node-4 Bump actions/setup-node from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for 61e3e27 - Browse repository at this point
Copy the full SHA 61e3e27View commit details -
Bump actions/checkout from 3 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 6b92823 - Browse repository at this point
Copy the full SHA 6b92823View commit details -
Merge pull request #160 from share/dependabot/github_actions/actions/…
…checkout-4 Bump actions/checkout from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for 92aee77 - Browse repository at this point
Copy the full SHA 92aee77View commit details
Commits on Jun 25, 2024
-
Merge pull request #159 from share/poll-delay-fix
✅ Fix a slightly flaky test
Configuration menu - View commit details
-
Copy full SHA for 02fbf78 - Browse repository at this point
Copy the full SHA 02fbf78View commit details
There are no files selected for viewing