Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide command echo #322

Open
millerlogic opened this issue Nov 3, 2019 · 1 comment
Open

Hide command echo #322

millerlogic opened this issue Nov 3, 2019 · 1 comment

Comments

@millerlogic
Copy link
Contributor

When I do a /command it looks like I spoke it to the room, would be nice if it looked different.

[chris] test
[chris] /help
-> Available commands:
...

test is a message, /help is a command, it looks like both are seen by all users.

I believe IRC clients don't show you what command you entered, that could work here if the command output was useful by itself. Consider /msg and /reply (perhaps others) where you would want to see what you typed.

Otherwise a simple solution would be to just show the command, not your [name].

Thoughts?

@shazow shazow changed the title Command display Hide command echo Nov 4, 2019
@shazow
Copy link
Owner

shazow commented Nov 4, 2019

Hi there, you're not the first person to get confused about that for sure, but a couple of counterpoints:

  • As you mentioned, in some cases it totally makes sense to show what you wrote (e.g. /msg), and we try to prioritize consistency when possible.
  • Many chat rooms do show the command, it really depends on what client you're using.

Also hiding the original message was not something that was technically possible before due to the way ssh-chat did rendering, but we recently changed the way we do ssh-chat's rendering so it is actually possible now.

Overall, I'm not opposed to making this change, but it's not a very high priority one right now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants