Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 1.18.2 Recipe transfer handler from Sophisticated Backpacks not working correctly with REI #10

Open
1 of 5 tasks
Raidobw2 opened this issue Jun 30, 2022 · 4 comments
Labels
bug Something isn't working transfer Related to TransferHandler

Comments

@Raidobw2
Copy link

What happened?

When using REI to craft, using the crafting upgrade in Sophisticated Backpacks, if the recipe doesn't use up all 9 spaces in the crafting grid, items are not placed in the correct locations for the recipe. This applies to recipes that have empty crafting grid slots.

Versions:
Minecraft 1.18.2
Forge 40.1.52
Modpack FTB Plexiglass Mountain 1.1.1

REI RoughlyEnoughItems-8.3.501.jar
REI Hacks RoughlyEnoughItems-jei-internals-workaround-8.3.501.jar
Architectury architectury-4.5.75-forge.jar
Sophisticated Backpacks sophisticatedbackpacks-1.18.2-3.17.5.602.jar
& required lib Sophisticated Core sophisticatedcore-1.18.2-0.3.5.48.jar


To reproduce:

  1. Have a Sophisticated backpack, with the Crafting Upgrade equipped
  2. Open said backpack, and switch to the crafting tab
  3. Pick an item from REI to test with (Prosperity Gemstone is a great example)
  4. Click the + to add it to the crafting grid
  5. See that items are not in the required shape

Using the + to transfer recipes, you end up with the following item placements.
On the top row, JEI.
On the bottom row, REI:
image

What mod loaders are you seeing the problem on?

Forge

What do you think this bug is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others

Relevant log output

It is simply registered and loaded as normal, though as you could see from the image the transfer does not put the items in the right spots

[23:47:47] [REI-ReloadPlugins/DEBUG] [REI] [START] Reloading Section: "reloadable-plugin/EntryTypeRegistryImpl/JEI Plugin [SBPPlugin:sophisticatedbackpacks:default] [sophisticatedbackpacks]/"
[23:47:47] [REI-ReloadPlugins/DEBUG] [REI] [START] Reloading Section: "reloadable-plugin/EntryTypeRegistryImpl/JEI Plugin [SBPPlugin:sophisticatedbackpacks:default] [sophisticatedbackpacks]/" done in 3.100 μs

Anything else?

Possibly it's this plugin since there's a bunch of JEI classes imported there
https://github.com/P3pp3rF1y/SophisticatedBackpacks/blob/debfc9c3136d9fe1434173716dc0d0909a7c715f/src/main/java/net/p3pp3rf1y/sophisticatedbackpacks/compat/jei/SBPPlugin.java#L95

Thanks so much!

@DanielB456
Copy link

I'm having a similar problem with this mod and the Crafting Terminal from Pretty Pipes. In this case: it will fill a recipe for crafting if it uses all 9 slots (Ex: Iron blocks, paintings, item frames). But if it doesn't need all 9 filled (Ex: Chests, Stairs, Slabs), it won't auto-fill into the crafting grid for item requesting.

@Raidobw2
Copy link
Author

@sayore
Copy link

sayore commented Aug 28, 2022

Man thats an annoying bug. Can confirm this one.

@shedaniel shedaniel transferred this issue from shedaniel/RoughlyEnoughItems Sep 17, 2022
@shedaniel shedaniel added the transfer Related to TransferHandler label Nov 17, 2022
@DUDEbehindDUDE
Copy link

Similar issue on 1.20.1, except it just says move items is not compatable with this inventory when in a backpack. Applies to all crafting upgrades (including stonecutter, furnace, etc.). See P3pp3rF1y/SophisticatedBackpacks#1066.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transfer Related to TransferHandler
Projects
None yet
Development

No branches or pull requests

5 participants