Ensure SingleAttestation conversion happens on the BeaconProcessor
#6805
Assignees
Labels
A0
electra
Required for the Electra/Prague fork
optimization
Something to make Lighthouse run more efficiently.
v7.0.0-beta.0
New release c. Q1 2025
Comments
michaelsproul
added
optimization
michaelsproul
changed the title
SingleAttestation conversion happens _on_ the BeaconProcessorSingleAttestation conversion happens on the BeaconProcessor
3 tasks
|
I'm going to work on a small standalone PR for this. |
This was referenced Feb 6, 2025
mergify bot
pushed a commit
that referenced
this issue
Feb 7, 2025
Closes - #6805 - Use a new `WorkEvent::GossipAttestationToConvert` to handle the conversion from `SingleAttestation` to `Attestation` _on_ the beacon processor (prevents a Tokio thread being blocked). - Improve the error handling for single attestations. I think previously we had no ability to reprocess single attestations for unknown blocks -- we would just error. This seemed to be the case in both gossip processing and processing of `SingleAttestation`s from the HTTP API. - Move the `SingleAttestation -> Attestation` conversion function into `beacon_chain` so that it can return the `attestation_verification::Error` type, which has well-defined error handling and peer penalties. The now-unused variants of `types::Attestation::Error` have been removed.
|
Fixed by: Part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In our
SingleAttestationMVP, the conversion fromSingleAttestationtoAttestationhappens on the main Tokio executor:SingleAttestationimplementation #6488We should ensure this is optimised out prior to shipping Electra. Some ideas for that here:
The other option is to more wholeheartedly embrace
SingleAttestation:SingleAttestationfull implementation #6616The text was updated successfully, but these errors were encountered: