Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

Error in forms example on landing page https://www.siimple.xyz/ #7

Open
tarator opened this issue May 30, 2019 · 3 comments
Open

Error in forms example on landing page https://www.siimple.xyz/ #7

tarator opened this issue May 30, 2019 · 3 comments
Assignees
Labels

Comments

@tarator
Copy link

tarator commented May 30, 2019

You have an error in your code example for form elements on your landing page:

Wrong (there is a closing </div> too much add the end and indentation is wrong):

<div class="siimple-field">
    <div class="siimple-field-label">Your email</div>
        <input type="email" class="siimple-input siimple-input--fluid" value="[email protected]">
        <div class="siimple-field-helper">Provide a valid email</div>
    </div>
    <div class="siimple-field">
        <div class="siimple-field-label">Your message</div>
        <textarea class="siimple-textarea siimple-textarea--fluid" rows="4">Siimple is awesome!</textarea>
    </div>
    <div class="siimple-field">
        <span class="siimple-btn siimple-btn--success">Submit</span>
        <span class="siimple-btn siimple-btn--error">Cancel</span>
    </div>
</div>

correct would be:

<div class="siimple-field">
    <div class="siimple-field-label">Your email</div>
    <input type="email" class="siimple-input siimple-input--fluid" value="[email protected]">
    <div class="siimple-field-helper">Provide a valid email</div>
</div>
<div class="siimple-field">
    <div class="siimple-field-label">Your message</div>
    <textarea class="siimple-textarea siimple-textarea--fluid" rows="4">Siimple is awesome!</textarea>
</div>
<div class="siimple-field">
    <span class="siimple-btn siimple-btn--success">Submit</span>
    <span class="siimple-btn siimple-btn--error">Cancel</span>
</div>
@jmjuanes jmjuanes added the bug label May 30, 2019
@jmjuanes jmjuanes self-assigned this May 30, 2019
@jmjuanes
Copy link
Member

Hello! Thanks for your issue.

I don't know where is the error, in the source code of the landing page the indentation is correct: https://github.com/siimple/website/blob/develop/index.html#L56

I have also checked the compiled static site generated with Jekyll and the indentation is correct...

Please, could you send me which is the file with the wrong indentation?

@tarator
Copy link
Author

tarator commented Jun 1, 2019

I marked in the screenshot, which div should be removed and where indentation should be corrected.
It's on the page https://siimple.xyz/

https://cloud.abenthung.it/s/Hgn9TiPG6DXEaWB

@jmjuanes
Copy link
Member

jmjuanes commented Jun 7, 2019

You are right, thank you! I will fix that asap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants