diff --git a/CHANGELOG.md b/CHANGELOG.md index fe01a43cb..1a3d6c91a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Changed - [SIL.Windows.Forms.Archiving] Split SIL.Archiving, moving Winforms portions (including dependency on L10nSharp) to SIL.Windows.Forms.Archiving. +- [SIL.Archiving] Changed IMDIArchivingDlgViewModel.ArchivingPackage to return an IMDIPackage (instead of an IArchivingPackage). - [SIL.Archiving] Required ArchivingDlgViewModel implementations to implement IDisposable. - [SIL.Archiving] Made protected members in ArchivingDlgViewModel private, adding protected accessors as needed. - [SIL.Archiving] In ArchivingDlgViewModel, renamed DisplayMessageEventHandler to MessageEventHandler, OnDisplayMessage to OnReportMessage, DisplayErrorEventHandler to ErrorEventHandler, and OnDisplayError to OnError. @@ -48,7 +49,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/). - [SIL.Archiving] Made ArchivingDlgViewModel.ArchiveType property public and changed it from a string to Standard (new enum). - [SIL.Archiving] Changed signature of setFilesToArchive delegate in ArchivingDlgViewModel's protected constructor. - [SIL.Archiving] Changed return type of ArchivingDlgViewModel.Initialize (to make it async) and added two parameters. -- [SIL.Archiving] Changed ArchivingDlgViewModel.DisplayMessage from public to protected. - [SIL.Archiving] Changed the signature of protected methods in ArchivingDlgViewModel: LaunchArchivingProgram, GetFileExcludedMsg. - [SIL.Archiving] Changed the signature of the public method ArchivingDlgViewModel.CreatePackage. - [SIL.Archiving] Changed underlying type of public enums VernacularMaterialsType and SilDomain from ulong to long. diff --git a/SIL.Archiving/ArchivingDlgViewModel.cs b/SIL.Archiving/ArchivingDlgViewModel.cs index 3c50a99a4..29e9d52df 100644 --- a/SIL.Archiving/ArchivingDlgViewModel.cs +++ b/SIL.Archiving/ArchivingDlgViewModel.cs @@ -453,7 +453,8 @@ protected void DisplayMessage(StringId msgId, MessageType type, params object[] } /// ------------------------------------------------------------------------------------ - protected void DisplayMessage(string msg, MessageType type) + [PublicAPI] + public void DisplayMessage(string msg, MessageType type) { OnReportMessage?.Invoke(msg, type); } diff --git a/SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs b/SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs index fb0abaab0..169044441 100644 --- a/SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs +++ b/SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs @@ -349,7 +349,7 @@ public IArchivingSession AddSession(string sessionId) return session; } - public IArchivingPackage ArchivingPackage => _imdiData; + public IMDIPackage ArchivingPackage => _imdiData; /// public new string PathToProgramToLaunch diff --git a/SIL.Windows.Forms.Keyboarding.Tests/App.config b/SIL.Windows.Forms.Keyboarding.Tests/App.config new file mode 100644 index 000000000..8a3d6d6d3 --- /dev/null +++ b/SIL.Windows.Forms.Keyboarding.Tests/App.config @@ -0,0 +1,13 @@ + + + + + + + + + + + + + \ No newline at end of file diff --git a/SIL.Windows.Forms.Keyboarding.Tests/SIL.Windows.Forms.Keyboarding.Tests.csproj b/SIL.Windows.Forms.Keyboarding.Tests/SIL.Windows.Forms.Keyboarding.Tests.csproj index a4fa46ae3..a4000c3f2 100644 --- a/SIL.Windows.Forms.Keyboarding.Tests/SIL.Windows.Forms.Keyboarding.Tests.csproj +++ b/SIL.Windows.Forms.Keyboarding.Tests/SIL.Windows.Forms.Keyboarding.Tests.csproj @@ -7,6 +7,7 @@ + @@ -15,6 +16,7 @@ + diff --git a/SIL.Windows.Forms.Tests/SIL.Windows.Forms.Tests.csproj b/SIL.Windows.Forms.Tests/SIL.Windows.Forms.Tests.csproj index 7d3c9e493..3a95c554f 100644 --- a/SIL.Windows.Forms.Tests/SIL.Windows.Forms.Tests.csproj +++ b/SIL.Windows.Forms.Tests/SIL.Windows.Forms.Tests.csproj @@ -22,6 +22,7 @@ + diff --git a/TestApps/ArchivingTestApp/ArchivingTestApp.csproj b/TestApps/ArchivingTestApp/ArchivingTestApp.csproj index 725af5e07..6f5d65f4b 100644 --- a/TestApps/ArchivingTestApp/ArchivingTestApp.csproj +++ b/TestApps/ArchivingTestApp/ArchivingTestApp.csproj @@ -2,7 +2,6 @@ WinExe - net8.0-windows enable false false @@ -13,7 +12,7 @@ - + diff --git a/TestApps/ArchivingTestApp/MainForm.cs b/TestApps/ArchivingTestApp/MainForm.cs index f8bcff64c..b0767f7e4 100644 --- a/TestApps/ArchivingTestApp/MainForm.cs +++ b/TestApps/ArchivingTestApp/MainForm.cs @@ -67,7 +67,7 @@ private void m_btnIMDI_Click(object sender, EventArgs e) foreach (var file in (from ListViewItem item in @group.Items select item.Text)) { session.AddFile(new ArchivingFile(file)); - session.AddFileAccess(file, (ArchivingPackage)model.ArchivingPackage); + session.AddFileAccess(file, model.ArchivingPackage); } session.Genre = "Dance";