Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: suppressImplicitAnyIndexErrors will be disallowed in Typescript 5.5 #1800

Closed
rmunn opened this issue Apr 30, 2024 · 0 comments · Fixed by #1817
Closed

debt: suppressImplicitAnyIndexErrors will be disallowed in Typescript 5.5 #1800

rmunn opened this issue Apr 30, 2024 · 0 comments · Fixed by #1817
Assignees

Comments

@rmunn
Copy link
Collaborator

rmunn commented Apr 30, 2024

Describe the code debt
We currently have suppressImplicitAnyIndexErrors in our tsconfig.json since we have a lot of implicit any types scattered throughout our code. That option will be going away in Typescript 5.5, so we'll need to turn suppressImplicitAnyIndexErrors off, see where these errors are occurring in our code, and fix them. Typescript says the fix is to "Add an index signature to the relevant type (or use a type assertion at the indexing location)."

To Fix
Steps to fix this:

  1. Remove "suppressImplicitAnyIndexErrors": true, from tsconfig.json
  2. Run make
  3. See what Typescript complains about
  4. Fix each error location individually
@rmunn rmunn self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this from To Do to Awaiting Testing (QA) in Language Forge Classic May 27, 2024
@megahirt megahirt moved this from Awaiting Testing (QA) to Awaiting PO sign off in Language Forge Classic Jun 26, 2024
@megahirt megahirt moved this from Awaiting PO sign off to Awaiting Deployment in Language Forge Classic Jun 26, 2024
@megahirt megahirt moved this from Awaiting Deployment to Done in Language Forge Classic Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant