Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break on decreasing LL #31

Open
simon-hirsch opened this issue Dec 9, 2024 · 0 comments
Open

Break on decreasing LL #31

simon-hirsch opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working discussion Deep technical discussions

Comments

@simon-hirsch
Copy link
Owner

We should allow breaking if the model gets worse. Currently we only check if the LL changes (better or worse).

There is a simple fix (i.e. just break) but the better solution would be to actually go back one step and recover the optimal model. Open questions to resolve this properly:

  • In the inner iteration, we can just "go back" one step.
  • In the outer iteration, we can go back on step or one distribution parameter.

Reported by Katarzyna Chec.

@simon-hirsch simon-hirsch self-assigned this Dec 9, 2024
@simon-hirsch simon-hirsch added bug Something isn't working discussion Deep technical discussions labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion Deep technical discussions
Projects
None yet
Development

No branches or pull requests

1 participant