Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of unneeded files? #189

Open
jaytavares opened this issue Feb 12, 2024 · 2 comments
Open

Cleanup of unneeded files? #189

jaytavares opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jaytavares
Copy link
Contributor

jaytavares commented Feb 12, 2024

After creating about 5 new functions projects and deleting the assets/ folder every time, I took a look in the src for this plugin to see if it would be an easy addition. To my surprise I found that the code already exists but is never called.

Is there a reason why it is never called?

@simondotm
Copy link
Owner

Wow! Great spot. Indeed, that code should be called but isn't.
Ok let's get that fixed for the next release then 👍

@simondotm simondotm added the bug Something isn't working label Feb 12, 2024
@simondotm
Copy link
Owner

Looking into this again, I believe I left assets in the function node app, just in case anyone wanted to override environment vars per function. Not sure how useful that is tbh. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants