Allow disabling the hidden preferences window. #2269
Conversation
This gives an option under advanced settings allowing the user to disable the hidden preferences window when applying settings (i.e., adding the hide-preferences-window class when caprine opens settings). This will be disabled by default (current behavior). If enabled, you'll very briefly see the settings window flash when caprine applies a setting inside Messenger.
|
I think this is a good way to implement a workaround, rather than having users remove the |
|
Cool. I'm guessing the process is to merge is someone with merge permissions will eventually review and merge this if accepted or come back with comments if there are changes requested? I looked through the contributing guidelines below and believe this should be good for review and merge whenever someone has a chance to take a look. :) |
|
Hey @sindresorhus, not a rush, but just plopping this on your radar if you have a chance to take a look. It's a small change to make working around issues of FB changing their UI easier to deal with. Details are in the description. |
|
Well said.
Dave Ducharme
Sent from Mailspring, the best free email app for work
…On Jan 15 2025, at 7:11 pm, Jonathan Stucklen ***@***.***> wrote:
Hey @sindresorhus ***@***.***/0?redirect=https%3A%2F%2Fgithub.com%2Fsindresorhus&recipient=cmVwbHkrQUFCSTJRS0tBWEI3UU81TVZUQjNUNkdGU1JNNE5FVkJOSEhLSU02RUhJQHJlcGx5LmdpdGh1Yi5jb20%3D), not a rush, but just plopping this on your radar if you have a chance to take a look. It's a small change to make working around issues of FB changing their UI easier to deal with. Details are in the description.
—
Reply to this email directly, view it on GitHub ***@***.***/1?redirect=https%3A%2F%2Fgithub.com%2Fsindresorhus%2Fcaprine%2Fpull%2F2269%23issuecomment-2594383024&recipient=cmVwbHkrQUFCSTJRS0tBWEI3UU81TVZUQjNUNkdGU1JNNE5FVkJOSEhLSU02RUhJQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe ***@***.***/2?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAABI2QKKRMGURRQHLM4OFDD2K4PMNAVCNFSM6AAAAABUCAMGTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJUGM4DGMBSGQ&recipient=cmVwbHkrQUFCSTJRS0tBWEI3UU81TVZUQjNUNkdGU1JNNE5FVkJOSEhLSU02RUhJQHJlcGx5LmdpdGh1Yi5jb20%3D).
You are receiving this because you are subscribed to this thread.
|
|
Actually, @mquevill, it looks like you're a maintainer for this repo. Given that the last commit I see from @sindresorhus himself was over 2 years ago, would you be ok to merge? It sounded like you thought it looked ok up above. |
This gives an option under advanced settings allowing the user to disable the hidden preferences window when applying settings (i.e., adding the hide-preferences-window class when caprine opens settings). This will be disabled by default (current behavior). If enabled, you'll very briefly see the settings window flash when caprine applies a setting inside Messenger.
Based on conversation here: #2265