feat(tooltip): refactor trigger prop to use TooltipTrigger type for i…

…mproved type safety
sipe-team · Dec 2, 2024 · 711788a · 711788a
1 parent 721a8c6
commit 711788a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/tooltip/src/Tooltip.tsx b/packages/tooltip/src/Tooltip.tsx
@@ -23,11 +23,13 @@ export type TooltipPosition =
   | 'left'
   | 'right';
 
+export type TooltipTrigger = 'hover' | 'click';
+
 export interface TooltipProps extends ComponentProps<'div'> {
   tooltipContent: ReactNode;
   placement?: TooltipPosition;
   asChild?: boolean;
-  trigger?: 'hover' | 'click';
+  trigger?: TooltipTrigger;
   tooltipStyle?: CSSProperties;
   tooltipClassName?: string;
   gap?: number;

diff --git a/packages/tooltip/src/hooks/useTooltip/useTooltip.tsx b/packages/tooltip/src/hooks/useTooltip/useTooltip.tsx
@@ -5,12 +5,12 @@ import {
   useRef,
   useState,
 } from 'react';
-import type { TooltipPosition } from '../../Tooltip';
+import type { TooltipPosition, TooltipTrigger } from '../../Tooltip';
 
 interface useTooltipProps {
   placement: TooltipPosition;
   gap: number;
-  trigger: 'hover' | 'click';
+  trigger: TooltipTrigger;
 }
 
 export function useTooltip({ placement, gap, trigger }: useTooltipProps) {
@@ -93,7 +93,7 @@ export function useTooltip({ placement, gap, trigger }: useTooltipProps) {
   const handleKeyDown = (event: ReactKeyboardEvent<HTMLDivElement>) => {
     if (
       (event.code === 'Enter' || event.code === 'space') &&
-      trigger === 'click'
+      (trigger === 'click' || trigger === 'touch')
     ) {
       event.preventDefault();
       toggleTooltip(!isVisible);