Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin causes a pimatic error when setting temperature via rules #3

Open
SenTzu01 opened this issue Apr 4, 2018 · 1 comment
Open

Plugin causes a pimatic error when setting temperature via rules #3

SenTzu01 opened this issue Apr 4, 2018 · 1 comment

Comments

@SenTzu01
Copy link

SenTzu01 commented Apr 4, 2018

changeTemperatureTo method of IntergasIncomfortHeatingThermostat does not return a promise, while methods exposed to the framework (accessible by rule actions) must always return a promise. Also see this post on the Pimatic forum.

I have fixed the issue on my fork, and will submit a pull request soon. Have also re-enabled debugging by adding the config setting to the plugin config, as well as some logging coming from the Lan2RF module.
@SenTzu01
Copy link
Author

SenTzu01 commented Apr 4, 2018

Pull request is ready for your review. Have tested against various setting scenarios via front end and rules. All tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SenTzu01