Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map erased / only markers + small area visible #170

Closed
mhnu16 opened this issue Jul 16, 2024 · 37 comments
Closed

Map erased / only markers + small area visible #170

mhnu16 opened this issue Jul 16, 2024 · 37 comments
Labels
bug Something isn't working

Comments

@mhnu16
Copy link

mhnu16 commented Jul 16, 2024

While playing on a modded server with my friends, I discovered that upon closing the game instance and re-entering the server, all of the area I explored gets deleted, while the markers I made remain.
I'm using "antique-atlas-2.9.12+1.21" and the server contains "surveyor-0.6.11+1.21.jar".

Here is the latest.log.

Example image:
image

@sisby-folk
Copy link
Owner

Can't seem to reproduce this on the same versions - is surveyor still configured default on both sides?
Does this still occur on a clean server with just antique atlas?

@amenbr1
Copy link

amenbr1 commented Aug 11, 2024

Same issue on LAN.
Everyone had the markers merged and map reset.
Nobody was using share at the time.

@ArkGrayer
Copy link

Having same issue here, when i close game i lost entire map and all markers merges with my client.
Idk why

@Krimatoria
Copy link

Krimatoria commented Aug 18, 2024

+1
2024-08-18_11 36 03

@sisby-folk sisby-folk added the bug Something isn't working label Aug 23, 2024
@SpaceNerd95251
Copy link

Just here to say +1, experienced this issue in multiplayer, minecraft version 1.20.1, surveyor version 0.6.23, atlas version 2.9.17

@Krimatoria
Copy link

Krimatoria commented Sep 8, 2024

Just here to say +1, experienced this issue in multiplayer, minecraft version 1.20.1, surveyor version 0.6.23, atlas version 2.9.17

it doesn't matter if the Surveyor Map Framework is worth it or without it, the same thing.

@sisby-folk sisby-folk changed the title Map gets deleted after closing the game Map erased / only markers + small area visible Sep 9, 2024
@EicoYT
Copy link

EicoYT commented Sep 9, 2024

Its been a while so the logs are somewhere but it would take a lot of time to search for them.
Unbenannt2
I cant say anything to how it happened like other people here but I only noticed after a while of playing I opened the map for the first time and saw that it isnt working and only the starting area is marked.

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

So I just tested older versions of both Antique Atlas 4 and Surveyor and it seems that if I stop the server after going in a new area and then directly start the server again and join again that area will be drawn on the map, Im doing more tests.

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

I wanna correct I only have to reconnect and then its drawn

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

latest.log
latest.log
the first is the server log and the second is the client log, I will shortly send a clip and then test the Antique atlas 4 newest version together with the surveyor newest version.

@sisby-folk
Copy link
Owner

I appreciate the logs so far, at this point I think what we really need is a reproduction case. If anyone can figure out when this happens using a fresh instance and a set of steps, it would be greatly appreciated.

Is this consistently on LAN Share? or does it happen on dedicated as well? can it happen in singleplayer?

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

I didnt see it happening in singleplayer and if you want I can do testing since it will benefital for me to on a new instance, this is a local server I set up on my pc.

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

new instance and new server with only these 4 mods
image
works, the map loads without problems even after leaving, shutting off server, shutting on server and joining again, works
latest.log
latest.log
heres again logs, the first is the server and the second is the client.

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

dude I dont know anymore, it may be because of an incompatible mod but then how big are the chances all these people have the same incompatible mod, can you tell me where antique atlas and/or surveyor saves their information about whats loaded on the map?

@sisby-folk
Copy link
Owner

sisby-folk commented Sep 9, 2024

(redacted for incorrect info, oops, thought this was another issue)

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

srry, what does that mean? I dont really understand that

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

does that mean you know what cuases this?

@sisby-folk
Copy link
Owner

oops, got this one confused with another issue - ignore me!

@EicoYT
Copy link

EicoYT commented Sep 9, 2024

alright

@SpaceNerd95251
Copy link

I can at least clarify my earlier comment and say it happened on a dedicated server, not on LAN

@SpaceNerd95251
Copy link

Some more info: I can confirm that things work as normal with singleplayer, even though I used the same instance of Prism as I normally use to join multiplayer. Though I suppose the issue in question could be a server side only mod that I don't have installed. In terms of multiplayer, exiting to the main menu and then rejoining the server works as expected; it is only when I exit to desktop and relaunch the instance that the problem occurs.

I know you have a lot at this point, but here's some logs, just in case it helps:
https://mclo.gs/uS9IRQH
https://mclo.gs/5GEtNDt

@Krimatoria
Copy link

#180
No it happens in a single player game too

This happens in a single player game and if you just open the world to the network, it doesn't matter. In each game, if you enter the world, the map will draw a part of the explored world. You will exit minecraft and close everything altogether. Then start Minecraft again, you will lose part of the map, most of it sometimes disappear and markers too, in short it is broken + other players who entered your world do not update the map, and the labels and part of the explored territories disappear.

@sisby-folk
Copy link
Owner

sisby-folk commented Sep 10, 2024

So to confirm your reproduction steps:

  • Create a new world
  • Click "open to LAN"
  • Save and quit
  • Exit the instance
  • Restart the instance
  • Reload the same world
  • Map appears emptied?

Does this occur in a fresh fabric 1.20.1 instance with just atlas and fapi?

@Krimatoria
Copy link

So to confirm your reproduction steps:

  • Create a new world
  • Click "open to LAN"
  • Save and quit
  • Exit the instance
  • Restart the instance
  • Reload the same world
  • Map appears emptied?

Does this occur in a fresh fabric 1.20.1 instance with just atlas and fapi?

I'm just a little busy right now, but the main way is to walk around the world and make TP somewhere far away, put labels there, upload the territory. Not only in the respawn place. I will add screenshots and playback paths before after later. No, I've only tried it with the forge connector.

@Krimatoria
Copy link

Krimatoria commented Sep 11, 2024

So to confirm your reproduction steps:

  • Create a new world
  • Click "open to LAN"
  • Save and quit
  • Exit the instance
  • Restart the instance
  • Reload the same world
  • Map appears emptied?

Does this occur in a fresh fabric 1.20.1 instance with just atlas and fapi?

I was playing on the server yesterday, putting tags.

I'm going to go into the world right now and see how the map has changed.

2024-09-11_01 11 57
2024-09-11_01 11 34
2024-09-11_01 11 39
By the way, when changing the scale, I noticed another point, there is a label, and the territory is cut off, although if you zoom in it is there, but this is a trifle.
2024-09-11_01 11 44
I specially made enlarged copies of the areas with labels that were far away.
2024-09-11_01 11 48

@Uranus-19AU
Copy link

I think dying might be the culprit, or at least one of the culprits. I've found a set of steps that works with just this mod installed (and fabric API), on a fresh instance. It doesn't even require that you close the game - just exiting and re-entering the world will do, so long as you do so after having died during your play session. Here's my log: https://mclo.gs/IdZiGPl

Recreate steps:

  1. Make a new world in creative with cheats enabled, and fly in a straight line for a bit to cover some terrain on the map
  2. Die and respawn
  3. Exit the world, and reopen it

You should find that any terrain you had explored is now gone, though any markers you placed will have persisted (such as the grave marker that gets placed automatically). Dying seems to put your game in a state where the map information will be lost upon exiting the world.

This might be an entirely separate bug to the ones that have been mentioned above, so apologies if this isn't the right place to put this.

@SpaceNerd95251
Copy link

The one's in my case werent to do with dying, it would happen whenever I fully closed the instance and relaunched it. Just exiting the world/server did not do anything. I didn't die during my testing, and the map did persist as you'd expect in singleplayer even when exiting and relaunching the game.

Again this is only in my case, and I haven't yet tried it with just antique atlas + surveyor (cause I don't have a good server to test it on) so it may be affected by mods or something idk

@SpaceNerd95251
Copy link

SpaceNerd95251 commented Sep 20, 2024

Update: I just was on my server for a bit, and I suddenly realized that my map is still there from the last session I played (technically two relogs ago, since prism crashed once today so I had to rejoin the server). This is the first time I've seen it not be deleted. I will let you know if I discover more. Maybe a mod was causing this, and whatever mod it was got updated?

Edit: It works. It just works. No idea why or how, but all of a sudden I can't get it to have an issue. It's persisting across fully relaunching and across dimension changes. Only thing I haven't tried is dying

@Krimatoria
Copy link

Krimatoria commented Sep 28, 2024

Is there an update planned to fix this error? At least approximately. @sisby-folk

@sisby-folk
Copy link
Owner

Appears to be an underlying issue in surveyor, I've had this reported on hoofprint as well (which tends to be easier to debug)

@Krimatoria
Copy link

And what does it mean?
[02:10:22] [Server thread/INFO] [surveyor/]: [Surveyor] Finished saving data for minecraft:overworld | cleaned 4 terrain regions, 1 structure regions, 0 landmarks
[02:10:29] [Server thread/INFO] [surveyor/]: [Surveyor] Finished saving data for minecraft:overworld | cleaned 4 terrain regions, 2 structure regions, 0 landmarks
[02:10:53] [Server thread/INFO] [surveyor/]: [Surveyor] Finished saving data for minecraft:overworld | cleaned 4 terrain regions, 0 structure regions, 1 landmarks

@Fyrelitee
Copy link

I'm having the same issue, also noticed that my map got reset except for markers when I opened to LAN and rejoined the world for a single player world. Is there any way to recover the map data from files in the folder? I had explored quite a large area and this is the second time it has happened, it would be a pain to refill it every time.

@pjon1
Copy link

pjon1 commented Oct 8, 2024

@Fyrelitee
If you have a backup of your world from before losing the data, you can copy it over. You can find it with an nbt editor under Data.Player.surveyor in your level.dat file or with /data get entity @p surveyor in-game.

@Fyrelitee
Copy link

@pjon1
Thanks! This worked, i'll just need to make a backup after every 'expedition' until this issue is resolved. For anyone else who finds this solution, https://nbt.mcph.to is a good online nbt editor, like pjon1 said above, in the level.dat file, navigate to Data > Player > surveyor and copy over the data.

@pjon1
Copy link

pjon1 commented Oct 9, 2024

i'll just need to make a backup after every 'expedition' until this issue is resolved.

You can try the fix here sisby-folk/surveyor#53 (comment)

@sisby-folk
Copy link
Owner

this should be fixed in 2.10 - thanks again @pjon1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants