-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figura path changed #50
Comments
sure thing - can you give me a minimum version that this change is / will be released in? |
There was some drama in the Figura community, so this should be in all current and future versions... I cannot vouch for this however as I'm not a part of the dev team. The only "current version" Figura I have, where this didn't get changed yet is the one from Modrinth... although that is a temporary build: All build artifacts (currently only official source of Figura for older MC versions) I've tried have already been updated however... |
🤭 I don't need a life story, I just need a value to put in the quilt.mod.json to prevent loading too-old versions of figura with this update. We need something with a clear dividing line, where the old package path had (semver) and the new package path has (different semver) - if a new numbered release hasn't come out yet, we'll wait until it does. if you're unsure, someone else can probably come in and catch us up when apt. |
Yeah, that's fair. Just kind of impatient and my attempts at making a custom build have been kind of all over the place :) |
Just looked through the repo, the version that is still in the gradle settings seems to be 0.1.1 (as seen here), however it seems like the next version with these changes is gonna be 0.1.2 (as seen here) |
sounds good - when 0.1.2 releases, we'll run a up a new version. Out of curiosity, are you actually using the Switchy figura lua api? if not, you should be able to remove the entrypoint from the quilt.mod.json by just opening the current Switchy jar in 7zip (should be in switchy-compat or switchy-compat-ui) |
hmm, did you have the Switchy figura api working before? or is this a new attempt - we haven't heard of anyone having immense success just yet. |
Yeah, it is unforunately kind of janky atm (I believe you chatted about this with Aproxia in DMs), but we got it working well enough. https://github.com/Octelly/octelly-figura/blob/main/src/modules/switchy.yue EDIT: Aproxia made an issue about it here: #51 |
can you link us through the new developer docs/wiki for figura? we remember them being threadbare but I'll see what I can do on both issues |
I wasn't aware there even was a dev wiki... |
Anyway, it's almost 5 am and I give up. My Java and its ecosystem knowledge isn't good enough for this. This seems like it should work, but I seem to be missing something. I don't know, guess I'll have to wait for Figura to get their stuff together. |
0.1.2 just released |
fixed in 0c6e04a |
I tried to run Switchy (2.8.4+1.20) with Figura (0.1.2+1.20.1) on 1.20.1. I suspect this change hasn't been replicated (Given the last commit was 3 weeks ago) and my game fails to start entirely. Logs extracted from my Relevant Logs[02:34:34] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.14.22 [02:34:35] [ForkJoinPool-1-worker-6/WARN]: The mod "switchy-compat-ui" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-7/WARN]: The mod "switchy-ui" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-8/WARN]: The mod "switchy-core" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-5/WARN]: The mod "switchy-client" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-6/WARN]: The mod "switchy-cardinal-ui" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-14/WARN]: The mod "switchy-cardinal" contains invalid entries in its mod json:
[02:34:35] [ForkJoinPool-1-worker-4/WARN]: The mod "switchy-compat" contains invalid entries in its mod json:
[02:34:35] [main/INFO]: Loading 70 mods: [02:34:35] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/C:/Users/{COMPUTER_USERNAME}/AppData/Roaming/com.modrinth.theseus/meta/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT [02:34:35] [main/INFO]: Compatibility level set to JAVA_16 [02:34:35] [main/INFO]: Compatibility level set to JAVA_17 [02:34:36] [main/WARN]: Error loading class: de/maxhenkel/voicechat/voice/client/RenderEvents (java.lang.ClassNotFoundException: de/maxhenkel/voicechat/voice/client/RenderEvents) [02:34:36] [main/WARN]: Error loading class: org/figuramc/figura/avatar/Avatar (java.lang.ClassNotFoundException: org/figuramc/figura/avatar/Avatar) [02:34:36] [main/WARN]: @mixin target org.figuramc.figura.avatar.Avatar was not found switchy-compat.mixins.json:compat.figura.AvatarMixin from mod switchy-compat ... [I stopped execution, seeing that last message but here's the next message I would've gotten] [HH:MM:SS] [Render thread/WARN]: |
I got nothing on that, that class clearly exists on the main branch here, right? https://github.com/FiguraMC/Figura/blob/1.20/common/src/main/java/org/figuramc/figura/avatar/Avatar.java |
I'm checking if it's my Java. |
Yeah i can reproduce this, reopening. |
Looks like it's on figura possibly, i'll open an issue. |
currently on switchy 2.8.4 (forge 1.20.1) & figura 0.1.3 pre3 (forge), may i ask how to make an edit so that it can refer to the right path? |
Figura is
org.figuramc.figura
now as seen here. Also lots of love for this mod <3The text was updated successfully, but these errors were encountered: