From 86074d14825d24ffbcd34ed961c4f7e97ab99e42 Mon Sep 17 00:00:00 2001 From: soulgalore Date: Fri, 27 Dec 2024 18:11:52 +0100 Subject: [PATCH] remove endpoint config --- .github/workflows/linux.yml | 2 +- lib/cli/cli.js | 4 ---- lib/plugins/gcs/index.js | 4 ---- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index e00f783b0b..6e8b4aecc4 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -84,4 +84,4 @@ jobs: - name: Run Chrome test using compare plugin run: node bin/sitespeed.js --compare.id compare --compare.saveBaseline --compare.baselinePath test/ http://127.0.0.1:3001/simple/ --xvfb - name: Run Chrome test sending data to GCS - run: node bin/sitespeed.js http://127.0.0.1:3001/simple/ --xvfb -n 1 --gcs.bucketname sitespeed --gcs.projectId sitespeed --gcs.apiEndpoint http://localhost:8081 \ No newline at end of file + run: STORAGE_EMULATOR_HOST="http://localhost:8081" node bin/sitespeed.js http://127.0.0.1:3001/simple/ --xvfb -n 1 --gcs.bucketname sitespeed --gcs.projectId sitespeed \ No newline at end of file diff --git a/lib/cli/cli.js b/lib/cli/cli.js index b1253a068f..b4bee5bc56 100644 --- a/lib/cli/cli.js +++ b/lib/cli/cli.js @@ -1698,10 +1698,6 @@ export async function parseCommandLine() { describe: 'Name of the Google Cloud storage bucket', group: 'GoogleCloudStorage' }) - .option('gcs.apiEndpoint', { - describe: 'The URL to the API endpoint, good for using fake-gcs-server', - group: 'GoogleCloudStorage' - }) .option('gcs.public', { describe: 'Make uploaded results to Google Cloud storage publicly readable.', diff --git a/lib/plugins/gcs/index.js b/lib/plugins/gcs/index.js index e00759c4e4..5ba09fc0cf 100644 --- a/lib/plugins/gcs/index.js +++ b/lib/plugins/gcs/index.js @@ -20,10 +20,6 @@ async function uploadLatestFiles(dir, gcsOptions, prefix) { keyFilename: gcsOptions.key }; - if (gcsOptions.apiEndpoint) { - config.apiEndpoint = gcsOptions.apiEndpoint; - } - const storage = new Storage(config); const bucket = storage.bucket(gcsOptions.bucketname);