Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording step with WPR doesn't care about emulated mobile mode #2653

Closed
soulgalore opened this issue Sep 23, 2019 · 2 comments
Closed

Recording step with WPR doesn't care about emulated mobile mode #2653

soulgalore opened this issue Sep 23, 2019 · 2 comments

Comments

@soulgalore
Copy link
Member

I think I've seen cases where we record with desktop size and then replying with emulated mobile, where some requests hasn't been recorded.
@soulgalore
Copy link
Member Author

I have a fix for this but lovell/sharp#1882 is stopping me from test it.

@soulgalore
Copy link
Member Author

Fixed by #2654 (after upstream issues been fixed in https://github.com/isaacs/minipass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soulgalore