Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The destroy callback handler of Dock bar item for plugin doesn't make sense #13762

Open
zxkmm opened this issue Jan 8, 2025 · 0 comments
Open
Assignees

Comments

@zxkmm
Copy link
Contributor

zxkmm commented Jan 8, 2025

Describe the problem

The destroy callback handler of Dock bar item for plugin doesn't make sense
Cuz there's no scene that apply "destroy" a Dock bar, cuz it cannot be destried whatsoever, hence there's no "delete" dock thing exist

solutions

  • either add a hide and show callback and keep the destroy one as is.
  • or make the destroy response Dock item hide ev and init when un-hide again.

刚才想了一下似乎第一种solution更合理,因为书签+插件似乎不会希望每次隐藏都销毁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants