Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verification for github #6

Open
skariel opened this issue Dec 26, 2024 · 2 comments
Open

add verification for github #6

skariel opened this issue Dec 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@skariel
Copy link
Owner

skariel commented Dec 26, 2024

No description provided.

@skariel skariel added the enhancement New feature or request label Dec 26, 2024
@skariel skariel self-assigned this Dec 26, 2024
@wizardishungry
Copy link
Contributor

Commenting on this because I saw that you wished to do the github integration via OAuth in TODO. Github exposes user keys in https://github.com/wizardishungry.keys so it would be possible to do this without OAuth. How do you envision 3rd party verifications fitting into the overall system? Should a user simply call register [email protected] and different register/confirm logic be triggered? Is this an avenue you'd like to pursue or would you prefer sticking to oauth so all 3rd party integrations look the same.

@skariel
Copy link
Owner Author

skariel commented Jan 1, 2025

not all users have their keys in github, but yeah for those that don't -- having the challenge of uploading them seems good. I'm not yet decided on OAuth vs custom logic per website. Some websites don't have OAuth, for e.g. HackerNews. Ideally there would be some kind of plugin system, each giving different registration options (different websites, methods etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants