fix: tx prioritization #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2024 18:36
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
davidterpay
approved these changes
Jun 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix * beauty * fix * fix * fix * test * lint * fix (cherry picked from commit b2dc571) # Conflicts: # tests/e2e/consumer.go
aljo242
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix: tx prioritization (#101) * fix * beauty * fix * fix * fix * test * lint * fix (cherry picked from commit b2dc571) # Conflicts: # tests/e2e/consumer.go * fix --------- Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--fee) into the txPriority calculation. This incorporates a notion of "payment over the base fee" that is used to actually derive your priority. We retain dividing bygas limitso that priority is denominated in "gas price"Coinpassed into the priority calculation will always be resolved to thefeemarketbase fee. This calculation is always truncated when going from DecCoins to CoinsGetTxPriorityto scale the values to integers. Previously, when gasPrices were < 1, nearly all priorities would just be truncated to 0. Added fuzz testing around this