Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] tagged objects and retrieval #1679

Open
fkiraly opened this issue Sep 21, 2024 · 0 comments
Open

[ENH] tagged objects and retrieval #1679

fkiraly opened this issue Sep 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 21, 2024

Related to this issue: #1582

Would it be useful to tag objects and make them available for retrieval?

The package contains neural networks and custom layers.

If we think, yes, then the "how" is the next question. Some thoughts:

  • torch objects do not mutate their init args, so they would be compliant with skbase, which brings its own tagging and retrieval system. Though I am not entirely sure whether we have compatibility, or whether we want to "weigh down" the torch objects.
  • alternatively, we could add records that are BaseObjects that point to the torch object. That may be safer, as the torch objects themselves would not inherit non-torch logic, which might be safer for upwards compatibility with torch. The idea here is a barebones BaseObject with tags, an __init__ with same params as the object, and with a build method that constructs the object instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant