Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Provider resource state #443

Closed
1 task
alexgeorgousis opened this issue Jan 22, 2025 · 0 comments
Closed
1 task

Track Provider resource state #443

alexgeorgousis opened this issue Jan 22, 2025 · 0 comments

Comments

@alexgeorgousis
Copy link
Contributor

alexgeorgousis commented Jan 22, 2025

Overview

The KFP Operator tracks the state of custom resources using a SynchronizationState field. It also sets a condition (SynchronizationSucceeded) that aligns with that field and adds K8s events (as outlined in #74).

We want to do the same for Provider resources so they aligns with our other custom resources. In the case of Providers, the SynchronizationState will track the state of the Deployment and Service that the provider controller manages.

Possible SynchronizationState values

  • Creating: If the Deployment or Service don't exist (in which case the controller will create them)
  • Updating: If the Deployment or Service exist but don't match the desired state described on the Provider resource (in which case the controller will update them to match)
  • Deleting: If the Provider resource has been deleted (in which case the controller will delete the Deployment and Service)
  • Succeeded: If the Provider resource reconciliation has completed with no failures
  • Failed: If the Provider resource reconciliation has failed for any reason
  • Deleted: This is used on custom resources that depend on a Provider to exist (e.g. Pipelines and RunConfigurations). It is used in any of these cases:
    • The resource has been successfully deleted (test If the Provider resource reconciliation has completed with no failures) - Note: This is a bit confusing - why (and how?) is the state set to Deleted when the resource has been deleted?
    • A deletion for a resource has been requested, but there is no provider ID set on the resource, and therefore the deletion cannot be carried out (test here and here) - This case doesn't apply to Provider resources

Acceptance Criteria

  • The Provider controller tracks the state of provider resources. The state consists of:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants