Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge local minikube and integration tests env setups #479

Open
alexgeorgousis opened this issue Feb 12, 2025 · 0 comments · May be fixed by #477
Open

Merge local minikube and integration tests env setups #479

alexgeorgousis opened this issue Feb 12, 2025 · 0 comments · May be fixed by #477

Comments

@alexgeorgousis
Copy link
Contributor

alexgeorgousis commented Feb 12, 2025

We currently have 2 minikube setups:

  • One spun up by the integration-test-up make target used for workflow factory integration tests
  • One spun up by the minikube-up make target used to provide a local manual testing environment

I think the 2 should be merged because:

  1. Makefile cohesion - it's strange to have 2 separate things that do something quite similar
  2. Provider tests: We should use 1 integration-test-up make target for all integration tests, but we need some things from minikube-up (e.g. installing the operator) for provider tests to work - so we might as well merge them instead of duuplicating
@alexgeorgousis alexgeorgousis linked a pull request Feb 13, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant