Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Skylight when running in development environment #3

Open
JonRCahill opened this issue Feb 22, 2017 · 1 comment
Open

Disable Skylight when running in development environment #3

JonRCahill opened this issue Feb 22, 2017 · 1 comment
Labels

Comments

@JonRCahill
Copy link
Contributor

Skylight currently runs in all environments even when a blank SKYLIGHT_AUTHENTICATION has been set. The biggest issue this causes is that shutting down the Phoenix server will take 1 min when integrated with Skylight. This additionally affects running tests with mix test if the server option has been enabled.

Happy to do this myself if I can be pointed to the best way to disable Skylight.

@wagenet
Copy link
Contributor

wagenet commented Feb 22, 2017

Thanks for catching this. The Ruby gem won't boot the native agent if there isn't a token, we should do the same here. Also, it should be possible to have the shutdown not block on the native daemon. The daemon won't shut down immediately but after a little bit will realize it's not getting anything from the main app and shut down on its own.

@wagenet wagenet added the bug label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants