ImportError: No module named upgrade

[agitator]

Happens with buildout.coredev 5.1

2016-06-20 13:36:31 INFO ZServer HTTP server started at Mon Jun 20 13:36:31 2016
    Hostname: 0.0.0.0
    Port: 8080
2016-06-20 13:36:34 ERROR PloneFormGen PloneFormGen requires Plone >= 4.1.
2016-06-20 13:36:34 ERROR Application Could not import Products.PloneFormGen
Traceback (most recent call last):
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/OFS/Application.py", line 606, in import_product
    product=__import__(pname, global_dict, global_dict, silly)
  File "/Users/peter/workspace/plone/eggs/Products.PloneFormGen-1.8.1-py2.7.egg/Products/PloneFormGen/__init__.py", line 21, in <module>
    from plone.app.upgrade import v41
ImportError: No module named upgrade
Traceback (most recent call last):
  File "/Users/peter/workspace/plone/parts/instance/bin/interpreter", line 295, in <module>
    exec(compile(__file__f.read(), __file__, "exec"))
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/Startup/run.py", line 76, in <module>
    run()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/Startup/run.py", line 22, in run
    starter.prepare()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/Startup/__init__.py", line 92, in prepare
    self.startZope()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/Startup/__init__.py", line 268, in startZope
    Zope2.startup()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/__init__.py", line 47, in startup
    _startup()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/Zope2/App/startup.py", line 67, in startup
    OFS.Application.import_products()
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/OFS/Application.py", line 583, in import_products
    import_product(product_dir, product_name, raise_exc=debug_mode)
  File "/Users/peter/workspace/plone/eggs/Zope2-2.13.24-py2.7.egg/OFS/Application.py", line 606, in import_product
    product=__import__(pname, global_dict, global_dict, silly)
  File "/Users/peter/workspace/plone/eggs/Products.PloneFormGen-1.8.1-py2.7.egg/Products/PloneFormGen/__init__.py", line 21, in <module>
    from plone.app.upgrade import v41
ImportError: No module named upgrade

[thet]

Do you depend on Products.CMFPlone or Plone?
plone.app.upgrade is a Plone dependency only.

[agitator]

fixed in https://github.com/collective/Products.PloneFormGen/

[mauritsvanrees]

Fixed where? You only link to an outdated fork of PloneFormGen.
I guess we need to add plone.app.upgrade to the install_requires in setup.py, or make the code not fail on an ImportError.

[agitator]

oops, fixed in collective@94ad48d collective@f177e85
collective@d6bc2b9
collective@ed07a32 collective@a054fb4

basically i simplified the existing version check, since the master is targeted on Plone 5 anyhow...?

honestly it's kind of confusing where the actual development/improvement happens, with a fork in the collective and 4 prs and 44 open issues in the original repository