-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do Not connect to youtube.com, do Not do anything with the watch history stored on it #116
Comments
If it fails to locate it in Youtube's history it is still deleted in the Watchmarker database and your browser history. So while this is annoying it is only taking longer due to having to wait for the Youtube lookup to fail. I will change the behavior and only delete it from Youtube's history if "mark a video as watched once it appears in Youtube's watch history" is checked in the setting. Similarly, I will only delete it from the browser history if "mark a video as watched once it appears in the browser's history" is checked in the settings. |
Ya it takes longer, but this is not the main thing, the main point is that it connects to youtube.com to remove the video from its history, which is unwanted,
And not touch the local db? I would like to request an offline mode:
Actually, the issue #92 is pretty much close to this issue:
|
That's what I was suggesting as well. 👍 |
I noticed one thing:
when I delete a video from the database, I see "3/4 locating it in the history on youtube" and then "error deleting video on youtube".
Do I understand it correctly that the extension tries to remove the video from the watch history on youtube itself?
(in this case "error deleting video on youtube" would be expected cause I don't have a google/youtube account, so am never logged in)
If yes, could you add an option (and set it as default) to never connect and touch the watch history on youtube itself, and only touch the local extension's database?
The text was updated successfully, but these errors were encountered: