Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Configure libraries according to build flavour/target. #636

Open
chitrak7 opened this issue Jun 26, 2018 · 3 comments
Open

Configure libraries according to build flavour/target. #636

chitrak7 opened this issue Jun 26, 2018 · 3 comments

Comments

@chitrak7
Copy link
Contributor

Currently, we configure libraries in package rules and they are configured in vanilla context. I think we should remove all instaces of vanilla context and replace them with flavors that they are built in or the targets.

This approach is not only confusing but creates a lot of errors. I think we should use input flavours even in the default target(stage1).
@angerman @snowleopard @alpmestan @izgzhen Any commnets/Suggestions??

@chitrak7
Copy link
Contributor Author

This issue also addresses the issue with #626 .

@alpmestan
Copy link
Collaborator

alpmestan commented Jun 27, 2018

I think this is the right way to go, yes. If we get a --flavour (or perf if none is given explicitly), we should then maybe assume that users want all the rules to just adapt the work they're doing to respect the ways dictated by the flavour, etc. vanillaContext is definitely overly used. We might want to think about whether we still want perf to be the default flavour for say validate or binary-dist, which in the make build system for most intents and purposes are suppose to be executed against a fixed flavour. But otherwise, following this principle sounds reasonable to me, and at least it gives us a principled way to figure out what to build and not to build and in what ways etc.

@snowleopard
Copy link
Owner

@chitrak7 I agree with @alpmestan's comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants