From 14f5f7ed7695154095b6ed6afc4a0ce015acf35e Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Wed, 3 Jan 2024 14:52:49 +1300 Subject: [PATCH 1/3] Add liburing package installation for Ubuntu tests. --- .github/workflows/test-external.yaml | 2 +- .github/workflows/test.yaml | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-external.yaml b/.github/workflows/test-external.yaml index e5f52f69..957ce400 100644 --- a/.github/workflows/test-external.yaml +++ b/.github/workflows/test-external.yaml @@ -25,7 +25,7 @@ jobs: - "3.2" - "3.3" - "head" - + steps: - uses: actions/checkout@v4 - uses: ruby/setup-ruby@v1 diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index fa1e3606..954a6f38 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -50,6 +50,10 @@ jobs: ruby-version: ${{matrix.ruby}} bundler-cache: true + - name: Install packages (Ubuntu) + if: matrix.os == 'ubuntu' + run: sudo apt-get install -y liburing + - name: Run tests timeout-minutes: 10 run: bundle exec bake build test From 4311f447fb3749a9b28de1475b902db402300e18 Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Wed, 3 Jan 2024 14:54:59 +1300 Subject: [PATCH 2/3] Fix liburing -> liburing-dev. --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 954a6f38..d4de9580 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -52,7 +52,7 @@ jobs: - name: Install packages (Ubuntu) if: matrix.os == 'ubuntu' - run: sudo apt-get install -y liburing + run: sudo apt-get install -y liburing-dev - name: Run tests timeout-minutes: 10 From c5a9359ab5c279807e4b0c0314b85cf137bc162d Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Wed, 3 Jan 2024 15:01:06 +1300 Subject: [PATCH 3/3] Improve warning. --- ext/io/event/selector/uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/io/event/selector/uring.c b/ext/io/event/selector/uring.c index 45002f8a..80640649 100644 --- a/ext/io/event/selector/uring.c +++ b/ext/io/event/selector/uring.c @@ -602,7 +602,7 @@ static inline off_t io_seekable(int descriptor) { return -1; } #else -#warning Upgrade your kernel to 5.16! io_uring bugs prevent efficient io_read/io_write hooks. +#warning Upgrade your kernel to 5.16+! io_uring bugs prevent efficient io_read/io_write hooks. static inline off_t io_seekable(int descriptor) { if (lseek(descriptor, 0, SEEK_CUR) == -1) {