Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal lint issues on Sheriff repo #172

Open
tomwhite007 opened this issue Jan 31, 2025 · 0 comments
Open

Internal lint issues on Sheriff repo #172

tomwhite007 opened this issue Jan 31, 2025 · 0 comments

Comments

@tomwhite007
Copy link
Contributor

This is only a suggestion—I'm happy for you to close it if you want. I'm just looking to improve DX.

Expected: As a developer, I would like to see only lint issues affecting my current file.

Actual: For .json and .html files in this repo, I see lint errors that pertain to .ts files. e.g.

Image

.js files also get lint errors for using CommonJS (require(...)) imports.

I propose you let me submit a small PR to convert eslint.config.js in the root to the format of a freshly created Nx repo. This would separate .ts lint rules away from .js, .json and .html files. If you have any special requirements that aren't standard linting rules, you could mention them here.

I'm suggesting this to improve my DX as I work on #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant