Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing BoundedInt terminal in ABIv2 parser #1467

Closed
kkawula opened this issue Sep 2, 2024 · 0 comments · Fixed by #1463
Closed

Fix parsing BoundedInt terminal in ABIv2 parser #1467

kkawula opened this issue Sep 2, 2024 · 0 comments · Fixed by #1463
Labels
bug Something isn't working tests

Comments

@kkawula
Copy link
Collaborator

kkawula commented Sep 2, 2024 •
edited
Loading

After new compiler release abi output looks like this core::internal::bounded_int::BoundedInt::<0, 79228162514264337593543950335> and isn't covered by our ABIv2 parser.

  • add new production to grammar
  • add new test that cover changes - similar to test_bounded_int_parse()
@kkawula kkawula mentioned this issue Sep 2, 2024
Merged
1 task
@kkawula kkawula added bug Something isn't working tests labels Sep 2, 2024
@kkawula kkawula assigned kkawula and unassigned kkawula Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bounded int parsing post cairo 2.8.0 feltroidprime/starknet-py-unbroken
1 participant
@kkawula