diff --git a/Sources/Starknet/Data/StarknetChainId.swift b/Sources/Starknet/Data/StarknetChainId.swift index 423256848..e69de29bb 100644 --- a/Sources/Starknet/Data/StarknetChainId.swift +++ b/Sources/Starknet/Data/StarknetChainId.swift @@ -1,20 +0,0 @@ -import BigInt -import Foundation - -public enum StarknetChainId: String, Codable, Equatable { - case mainnet = "0x534e5f4d41494e" - case goerli = "0x534e5f474f45524c49" - case sepolia = "0x534e5f5345504f4c4941" - case integration_sepolia = "0x534e5f494e544547524154494f4e5f5345504f4c4941" - - public var feltValue: Felt { - Felt(fromHex: self.rawValue)! - } - - enum CodingKeys: String, CodingKey { - case mainnet = "0x534e5f4d41494e" - case goerli = "0x534e5f474f45524c49" - case sepolia = "0x534e5f5345504f4c4941" - case integration_sepolia = "0x534e5f494e544547524154494f4e5f5345504f4c4941" - } -} diff --git a/Sources/Starknet/Data/Transaction/TransactionHash.swift b/Sources/Starknet/Data/Transaction/TransactionHash.swift index d1daf84eb..df4289d22 100644 --- a/Sources/Starknet/Data/Transaction/TransactionHash.swift +++ b/Sources/Starknet/Data/Transaction/TransactionHash.swift @@ -11,7 +11,7 @@ public class StarknetTransactionHashCalculator { entryPointSelector: Felt, calldata: StarknetCalldata, maxFee: Felt, - chainId: StarknetChainId, + chainId: Felt, nonce: Felt ) -> Felt { StarknetCurve.pedersenOn( @@ -21,12 +21,12 @@ public class StarknetTransactionHashCalculator { entryPointSelector, StarknetCurve.pedersenOn(calldata), maxFee, - chainId.feltValue, + chainId, nonce ) } - private class func prepareCommonTransactionV3Fields(of transaction: any StarknetTransactionV3, address: Felt, chainId: StarknetChainId) -> [Felt] { + private class func prepareCommonTransactionV3Fields(of transaction: any StarknetTransactionV3, address: Felt, chainId: Felt) -> [Felt] { let transactionType = transaction.type let version = transaction.version let tip = transaction.tip @@ -45,7 +45,7 @@ public class StarknetTransactionHashCalculator { + StarknetTransactionHashCalculator.resourceBoundsForFee(resourceBounds) ), StarknetPoseidon.poseidonHash(paymasterData), - chainId.feltValue, + chainId, nonce, StarknetTransactionHashCalculator.dataAvailabilityModes( feeDataAvailabilityMode: feeDataAvailabilityMode, @@ -54,7 +54,7 @@ public class StarknetTransactionHashCalculator { ] } - public class func computeHash(of transaction: StarknetInvokeTransactionV1, chainId: StarknetChainId) -> Felt { + public class func computeHash(of transaction: StarknetInvokeTransactionV1, chainId: Felt) -> Felt { computeCommonDeprecatedTransactionHash( transactionType: transaction.type, version: transaction.version, @@ -67,7 +67,7 @@ public class StarknetTransactionHashCalculator { ) } - public class func computeHash(of transaction: StarknetInvokeTransactionV3, chainId: StarknetChainId) -> Felt { + public class func computeHash(of transaction: StarknetInvokeTransactionV3, chainId: Felt) -> Felt { let commonFields = StarknetTransactionHashCalculator.prepareCommonTransactionV3Fields( of: transaction, address: transaction.senderAddress, @@ -81,7 +81,7 @@ public class StarknetTransactionHashCalculator { ) } - public class func computeHash(of transaction: StarknetDeployAccountTransactionV1, chainId: StarknetChainId) -> Felt { + public class func computeHash(of transaction: StarknetDeployAccountTransactionV1, chainId: Felt) -> Felt { let contractAddress = StarknetContractAddressCalculator.calculateFrom( classHash: transaction.classHash, calldata: transaction.constructorCalldata, @@ -102,7 +102,7 @@ public class StarknetTransactionHashCalculator { ) } - public class func computeHash(of transaction: StarknetDeployAccountTransactionV3, chainId: StarknetChainId) -> Felt { + public class func computeHash(of transaction: StarknetDeployAccountTransactionV3, chainId: Felt) -> Felt { let contractAddress = StarknetContractAddressCalculator.calculateFrom( classHash: transaction.classHash, calldata: transaction.constructorCalldata, diff --git a/Sources/Starknet/Providers/StarknetProvider/StarknetProvider.swift b/Sources/Starknet/Providers/StarknetProvider/StarknetProvider.swift index fa5958125..3aa1e0bfa 100644 --- a/Sources/Starknet/Providers/StarknetProvider/StarknetProvider.swift +++ b/Sources/Starknet/Providers/StarknetProvider/StarknetProvider.swift @@ -178,10 +178,10 @@ public class StarknetProvider: StarknetProviderProtocol { return result } - public func getChainId() async throws -> StarknetChainId { + public func getChainId() async throws -> Felt { let params = EmptySequence() - let result = try await makeRequest(method: .getChainId, params: params, receive: StarknetChainId.self) + let result = try await makeRequest(method: .getChainId, params: params, receive: Felt.self) return result } diff --git a/Sources/Starknet/Providers/StarknetProviderProtocol.swift b/Sources/Starknet/Providers/StarknetProviderProtocol.swift index ea11fab41..a71ea5087 100644 --- a/Sources/Starknet/Providers/StarknetProviderProtocol.swift +++ b/Sources/Starknet/Providers/StarknetProviderProtocol.swift @@ -127,7 +127,7 @@ public protocol StarknetProviderProtocol { /// Get the currently configured Starknet chain id /// /// - Returns: The Starknet chain id - func getChainId() async throws -> StarknetChainId + func getChainId() async throws -> Felt /// Simulate running a given list of transactions, and generate the execution trace /// diff --git a/Tests/StarknetTests/Providers/ProviderTests.swift b/Tests/StarknetTests/Providers/ProviderTests.swift index 240cb1b22..4ee6e5d68 100644 --- a/Tests/StarknetTests/Providers/ProviderTests.swift +++ b/Tests/StarknetTests/Providers/ProviderTests.swift @@ -51,7 +51,7 @@ final class ProviderTests: XCTestCase { func testGetChainId() async throws { let chainId = try await provider.getChainId() - XCTAssertEqual(chainId, .goerli) + XCTAssertEqual(chainId.toShortString(), "SN_GOERLI") } func testSpecVersion() async throws {