Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open to PRs? #3

Open
cmorganBE opened this issue Jan 4, 2024 · 2 comments
Open

Open to PRs? #3

cmorganBE opened this issue Jan 4, 2024 · 2 comments

Comments

@cmorganBE
Copy link

We've got some use for this for internal testing of a blufi enabled system, this looks like the best (and maybe the only?) python blufi implementation. Would you be open to reviewing any PRs we had? I figured I'd ask before we submit any in case this isn't the case and we should instead carry our own fork.
@someburner
Copy link
Owner

someburner commented Jan 5, 2024 •
edited
Loading

yeah totally. The use / API is all experimental and fairly rough draft. Open to PRs or even recommending a maintained fork for others.

I searched fairly long and hard for an existing implementation before doing it myself.

@cmorganBE
Copy link
Author

Appreciate the work you've done here. If/when I have some suggestions for changes I'll open up some PRs for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@someburner @cmorganBE