Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for 2D spot detection with TrackPy #1813

Open
ttung opened this issue Feb 12, 2020 · 3 comments
Open

support for 2D spot detection with TrackPy #1813

ttung opened this issue Feb 12, 2020 · 3 comments
Labels
bug An issue with an existing feature

Comments

@ttung
Copy link
Collaborator

ttung commented Feb 12, 2020

Description

#1808 erroneously removed the code that detected whether we are working with 2d or 3d data. however, it is possible to call trackpy spot detection with is_volume=False and get 2d slices. that will bomb the existing code.

It is not a simple matter of reverting #1808, because even without #1808, the code will bomb later on in the constructor of PerImageSliceSpotResults, where the absence of z data will trigger an assertion.
@ttung ttung added the bug An issue with an existing feature label Feb 12, 2020
@ttung
Copy link
Collaborator Author

ttung commented Feb 12, 2020

It's quite likely that local_max_peak_finder has some bugs too!

@ttung
Copy link
Collaborator Author

ttung commented Feb 12, 2020 •
edited
Loading

ok local_max_peak_finder has a different set of bugs which I will document elsewhere.

EDIT: in #1814 and #1815

@ttung
Copy link
Collaborator Author

ttung commented Feb 13, 2020

Update: we should make trackpy work in 2D.

@neuromusic neuromusic changed the title trackpy spot detection with 2d slices will bomb support for 2D spot detection with TrackPy Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue with an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttung