Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java-related configuration from build.gradle for Kotlin projects #211

Closed
wilkinsona opened this issue Mar 31, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@wilkinsona
Copy link
Contributor

I don't think target and source compatibility make sense:

sourceCompatibility = 1.8
targetCompatibility = 1.8

I'm also not sure about the configuration of Eclipse's classpath, but I'd have to look at Kotlin's Eclipse plugin more closely to be sure.

eclipse {
    classpath {
         containers.remove('org.eclipse.jdt.launching.JRE_CONTAINER')
         containers 'org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8'
    }
}

If the above isn't needed, then it might also be possible to stop applying the Eclipse plugin too.

@snicoll
Copy link
Contributor

snicoll commented Dec 30, 2016

@wilkinsona the last bits are removed as part of #275 - As for the rest, isn't that there for cross-compilation? We do support java+groovy for Groovy-based projects. Doesn't it make sense for Kotlin-based projects? ping @sdeleuze

@sdeleuze
Copy link
Contributor

sdeleuze commented Jan 2, 2017

While mixed Java + Kotlin project are common on existing Java project, I tend to think most Kotlin newly created projects will just use Kotlin code, so indeed that could make sense to remove sourceCompatibility and targetCompatibility.

@mhalbritter
Copy link
Contributor

With the switch to toolchains in #1227 these bits have been removed.

@mhalbritter mhalbritter added this to the 0.21.0 milestone Jun 5, 2024
@mhalbritter mhalbritter self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants