Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert an implementation of IndexedData to a Record. #2806

Closed
junghoon-vans opened this issue Dec 14, 2023 · 1 comment
Closed

Convert an implementation of IndexedData to a Record. #2806

junghoon-vans opened this issue Dec 14, 2023 · 1 comment
Assignees
@christophstrobl
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@junghoon-vans
Copy link
Contributor

Record is Java's inconvenience data class, so it's a great fit for IndexedData for holding and passing data.
It's also nice not to have to define getters or methods like hashcode and equals, especially if it changes.
@junghoon-vans junghoon-vans mentioned this issue Dec 14, 2023
Closed
4 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 14, 2023
@christophstrobl
Copy link
Member

Thank you for getting in touch.
While records are a great enhancement, simply switching class to record, especially for public API, breaks, as you probably noticed when creating the PR, existing contracts.
Therefore I'll close this issue.

@christophstrobl christophstrobl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@christophstrobl christophstrobl added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert an Implementation of IndexedData to a Record. junghoon-vans/spring-data-redis
3 participants
@christophstrobl @spring-projects-issues @junghoon-vans