-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize a MessagingMessageListenerAdapter
returning null
from the DelegatingInvocableHandler.invoke()
#3697
Open
Labels
Milestone
Comments
Hi, @artembilan! Could I work on this issue? Thanks! |
@ivamly Yes, please go ahead. |
ivamly
added a commit
to ivamly/spring-kafka
that referenced
this issue
Jan 16, 2025
…turning null from the DelegatingInvocableHandler.invoke()
ivamly
added a commit
to ivamly/spring-kafka
that referenced
this issue
Jan 16, 2025
ivamly
added a commit
to ivamly/spring-kafka
that referenced
this issue
Jan 16, 2025
…turning null from the DelegatingInvocableHandler.invoke() Signed-off-by: ivamly <[email protected]>
ivamly
added a commit
to ivamly/spring-kafka
that referenced
this issue
Jan 16, 2025
…rn null Signed-off-by: ivamly <[email protected]>
spring-builds
pushed a commit
that referenced
this issue
Jan 16, 2025
* Optimize a MessagingMessageListenerAdapter returning null from the DelegatingInvocableHandler.invoke() Fixes: #3697 Signed-off-by: ivamly <[email protected]> (cherry picked from commit 004fd52)
sobychacko
added a commit
to sobychacko/spring-kafka
that referenced
this issue
Jan 16, 2025
…eturning null " This reverts commit 004fd52.
See the comment on the latest PR. |
I'll make another PR soon, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the
DelegatingInvocableHandler.invoke()
always returns anInvocationResult
even ifresult == null
.In the end we may just have a log message like:
which is not always true for the regular
void @KafkaHandler
method.Changing the logic in the mention method to:
would make some optimization where we would not try to resolve any reply attempts and creation of many interim objects like
CompletableFuture
.Since this would be a breaking change, the issue is scheduled for the next
4.0
major version.The text was updated successfully, but these errors were encountered: