Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spring index] replace EnhancedSymbolInformation for beans with new spring index information #1041

Closed
martinlippert opened this issue May 10, 2023 · 3 comments
Closed

[spring index] replace EnhancedSymbolInformation for beans with new spring index information #1041

martinlippert opened this issue May 10, 2023 · 3 comments
Assignees
@martinlippert
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Milestone
4.28.0.RELEASE

Comments

@martinlippert
Copy link
Member

The enhanced symbol information for BeansSymbolAddOnInformation doesn't seem to be necessary anymore given the new spring index that provides the same information, so we should remove BeansSymbolAddOnInformation and use the new spring index instead we necessary.
@martinlippert martinlippert added type: enhancement theme: spring index & symbols for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode labels May 10, 2023
@martinlippert martinlippert added this to the 4.19.0.RELEASE milestone May 10, 2023
@martinlippert martinlippert self-assigned this May 10, 2023
@martinlippert martinlippert modified the milestones: 4.19.1.RELEASE, Backlog Aug 1, 2023
@martinlippert
Copy link
Member Author

This is used by the XML bean ref content-assist and definition providers, so a prerequisite of this is to integrate the XML symbol scanning into the new bean index.

@martinlippert
Copy link
Member Author

First steps: 24492fe, d81feb0, 9bffd04, 2e7db46, 7a83c07

martinlippert added a commit that referenced this issue Jan 6, 2025
@martinlippert
GH-1041: removed feign-specific symbol addon information and rebased …
133516b 
…implementation on spring index
martinlippert added a commit that referenced this issue Jan 8, 2025
@martinlippert
GH-1041: bean now knows whether it is a configuration bean or not
02e3ede
martinlippert added a commit that referenced this issue Jan 9, 2025
@martinlippert
GH-1041: reconciler that finds non-registered aot processor beans upd…
44e4974 
…ated to use spring index instead of symbols
martinlippert added a commit that referenced this issue Jan 9, 2025
@martinlippert
GH-1041: removed special symbols addon class for config beans, not ne…
7c40f30 
…cessary anymore
martinlippert added a commit that referenced this issue Jan 10, 2025
@martinlippert
GH-1041: removed outdated beans addon symbol information, now fully r…
435cd59 
…eplaced with new spring index
@martinlippert martinlippert modified the milestones: Backlog, 4.28.0.RELEASE Jan 10, 2025
martinlippert added a commit that referenced this issue Jan 15, 2025
@martinlippert
GH-1041: replaced webflux symbol addon information objects with new i…
21accae 
…ndex child nodes

some additional groundwork for nested structure inside of spring index, in support of GH-1425, GH-1431, GH-1424
martinlippert added a commit that referenced this issue Jan 16, 2025
@martinlippert
GH-1041: finally removing main obsolete symbol add-on information int…
778cacf 
…erface
@martinlippert martinlippert mentioned this issue Jan 16, 2025
Closed
@martinlippert
Copy link
Member Author

Closing this for now and the 4.28.0 release cycle. All of the SymbolAddOnInformation classes have been removed and replaced successfully. The final step here is #1450, which is scheduled for the 4.29.0 release cycle.

martinlippert added a commit that referenced this issue Feb 7, 2025
@martinlippert
GH-1041: removed enhanced bean symbol wrapper class as a final step
6698801 
Fixes GH-1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlippert martinlippert

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Projects
None yet
Milestone
4.28.0.RELEASE
Development

No branches or pull requests
1 participant
@martinlippert