Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP_CodeSniffer Contributor Update #3814

Open
gsherwood opened this issue Apr 30, 2023 · 1 comment
Open

PHP_CodeSniffer Contributor Update #3814

gsherwood opened this issue Apr 30, 2023 · 1 comment
Labels
Type: meta

Comments

@gsherwood
Copy link
Member

It wont come as a surprise to anyone who has been watching this project, but I've had very little time to work on PHP_CodeSniffer over the last couple of years, and the last 12 months in particular. The result is that the PR backlog isn't being worked through, releases are infrequent, and the project isn't keeping up with PHP syntax changes.

To help, @jrfnl has been given write access to the repository as of today. Together, we'll work through the backlog of PRs and feature requests, so expect to see commits and merges coming from both of us.

@jrfnl has been the top contributor to PHP_CodeSniffer for several years and worked on most of the new syntax support and testing improvements, as well as working on a number of high-profile packages surrounding PHP_CodeSniffer and the wider PHP community.

Thank you @jrfnl for all your work on PHP_CodeSniffer so far, and I look forward to working with you more closely from now on.
@gsherwood gsherwood pinned this issue Apr 30, 2023
This was referenced May 16, 2023
Merged
Merged
@janedbal janedbal mentioned this issue Aug 1, 2023
Closed
@jrfnl
Copy link
Contributor

jrfnl commented Dec 1, 2023

Follow up: #3932

@jrfnl jrfnl unpinned this issue Dec 1, 2023
jrfnl added a commit to PHPCSStandards/PHPCSDevTools that referenced this issue Dec 1, 2023
@jrfnl
TODO: CHECK ISSUE URL | Switch to PHPCSStandards/PHP_CodeSniffer
67a1e85 
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.

Note: I'm not changing the version constraints. All tags since 2.0.0 have been recreated in the PHPCSStandards fork, though the package name in those tags has not been changed.

Based on tests I've run, the package should install fine when old tags are requested, though if a user has a `composer.json` which _also_ includes `squizlabs/php_codesniffer` in their dependency chain, this means that both will be installed, which could lead to issues.

I recommend tagging a release straight-away. This should then allow _our_ dependencies to update their own requirements and version constraints and to release, to prevent these type of problems.

Ref:
* squizlabs/PHP_CodeSniffer#3814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsherwood @jrfnl