New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments for blobs.get #57

Open

retog opened this issue Oct 2, 2021 · 1 comment

retog commented Oct 2, 2021

According to https://ssbc.github.io/scuttlebutt-protocol-guide/#fetching a valid argument for blobs.get would be

{"hash":"&KYWW5Lblhq2moFO9BJhtJ5WukFRpA7eYybOwdODTt3M=.sha256","max":5242880}

However, the reference implementation is sending

{"key":"&KYWW5Lblhq2moFO9BJhtJ5WukFRpA7eYybOwdODTt3M=.sha256","max":5242880}

see: ssbc/ssb-blobs@c394333

The text was updated successfully, but these errors were encountered:

Member

arj03 commented Oct 3, 2021

Looks correct, can you provide a PR? Looks like getSlice also needs an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment