Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do tangle previous pruning iff the message is actually too big #25

Open
Powersource opened this issue Oct 25, 2022 · 5 comments
Open

Comments

@Powersource
Copy link
Collaborator

Being added in this PR #19

ssb.db.create({ content, encryptionFormat: 'box2' }, (err, msg) => {
if (err) {

Right now we assume that create errors because the message is too big, but that's something we could check, like mix says:

we could actually check the error message includes "Too large" or something

@staltz
Copy link
Member

staltz commented Nov 3, 2022

@Powersource Can we close this?

@Powersource
Copy link
Collaborator Author

No

@staltz
Copy link
Member

staltz commented Nov 3, 2022

@Powersource what's missing? I see PR #19 merged.

@Powersource
Copy link
Collaborator Author

This issue is because #19 was merged. Right now we do pruning whether or not the message is too big. If we add a check that the error is specifically because the message is too big or not, then we could error faster when it didn't error because of the size.

@staltz staltz added the should Needed in production label Nov 3, 2022
@staltz
Copy link
Member

staltz commented Nov 3, 2022

Okay, thanks

@Powersource Powersource removed the should Needed in production label Dec 12, 2022
@Powersource Powersource changed the title Only do tangle previous pruning if the message is actually too big Only do tangle previous pruning iff the message is actually too big Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants