-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only do tangle previous
pruning iff the message is actually too big
#25
Comments
3 tasks
@Powersource Can we close this? |
No |
@Powersource what's missing? I see PR #19 merged. |
This issue is because #19 was merged. Right now we do pruning whether or not the message is too big. If we add a check that the error is specifically because the message is too big or not, then we could error faster when it didn't error because of the size. |
Okay, thanks |
Powersource
changed the title
Only do tangle
Only do tangle Feb 6, 2023
previous
pruning if the message is actually too bigprevious
pruning iff the message is actually too big
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Being added in this PR #19
ssb-tribes2/lib/prune-publish.js
Lines 8 to 9 in da29c04
Right now we assume that
create
errors because the message is too big, but that's something we could check, like mix says:The text was updated successfully, but these errors were encountered: