Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for version tag to only have TAG without SHA #30

Open
oyamin opened this issue Jul 29, 2022 · 2 comments
Open

Support for version tag to only have TAG without SHA #30

oyamin opened this issue Jul 29, 2022 · 2 comments

Comments

@oyamin
Copy link

oyamin commented Jul 29, 2022

Currently, the when I merge to master/main branch, the tag for helm it generates is "0.2.0+70d13ed" while the git tag is just 0.2.0. Even when I specify helm release CHART -t 0.2.0 It still adds SHA at the end.

I know I can achieve that with using: helm release . --source helm --bump patch

But, I am trying to implement this in our CI/CD pipeline, which would use semantic-release plugin, and use the git tag that is generated from that commit. semantic-release plugin tag is generated automatically off the commit message, like "fix:" or "feat:". That way, I don't have to update the pipeline every time manually with major, minor, or patch (if I use --source helm).

I was wondering if there is a possibility to add an option/arg which would generate the Chart version without the SHA in git source, like it does when I use --source helm?

@sstarcher
Copy link
Owner

That's certainly possible. The +SHA option is a valid semantic version convention.

A change could be made to this code base to supply an option to not output +SHA. Or you can use bash to strip off +SHA and have your CI system use that logic.

@oyamin
Copy link
Author

oyamin commented Aug 2, 2022

One of the reasons I want use helm-release is because it automatically updates Charts.yaml and values.yaml with the new version. If I where going to use bash to remove the SHA, I might as well just use sed to replace the values in Chart.yaml and values.yaml with the new TAG generated by semantic-release plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants