Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for cosine losses #8

Open
dgfl-gh opened this issue Aug 24, 2020 · 3 comments
Open

Account for cosine losses #8

dgfl-gh opened this issue Aug 24, 2020 · 3 comments

Comments

@dgfl-gh
Copy link
Collaborator

dgfl-gh commented Aug 24, 2020

Persist the dot product between the engine thrust vector and vessel forward vector to account for cosine losses during persistent thrust

@sswelm
Copy link
Owner

sswelm commented Aug 24, 2020

I think we have to assume a thrust vector always aligns with a part transform up vector. Then its just a matter of taking the cosine of the part up transform against the vessel.

@dgfl-gh
Copy link
Collaborator Author

dgfl-gh commented Aug 24, 2020

Yes, should be a safe assumption anyway; never seen an engine (except maybe some VTOL engines that no one is going to use in PT) that didn't have it thrust on its up direction

@dgfl-gh
Copy link
Collaborator Author

dgfl-gh commented Dec 15, 2020

Should be working, but still trying to properly test if it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants