You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While reviewing #174, @jpvillaisaza realized (see #174 (comment)) that I had accidentally removed the call to dropOldReleases when a successful release was deployed, so old releases weren't being deleted; despite of this, my PR did pass the CI checks. This made clear that we need to add a test to check for that, as this behavior is to be expected since by default no more than 5 releases should be preserved unless the user increases that with the keep_releases setting via config.
The text was updated successfully, but these errors were encountered:
While reviewing #174, @jpvillaisaza realized (see #174 (comment)) that I had accidentally removed the call to
dropOldReleases
when a successful release was deployed, so old releases weren't being deleted; despite of this, my PR did pass the CI checks. This made clear that we need to add a test to check for that, as this behavior is to be expected since by default no more than 5 releases should be preserved unless the user increases that with thekeep_releases
setting via config.The text was updated successfully, but these errors were encountered: