Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test that checks old releases are dropped after a deployment #177

Open
DavidMazarro opened this issue Feb 8, 2022 · 0 comments
Open

Comments

@DavidMazarro
Copy link
Member

While reviewing #174, @jpvillaisaza realized (see #174 (comment)) that I had accidentally removed the call to dropOldReleases when a successful release was deployed, so old releases weren't being deleted; despite of this, my PR did pass the CI checks. This made clear that we need to add a test to check for that, as this behavior is to be expected since by default no more than 5 releases should be preserved unless the user increases that with the keep_releases setting via config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants