[feature] support reclaim from Ledger #1255
Conversation
MCJOHN974
changed the title
|
From my understanding this adds all we need on sbtc side. I'd maybe also add some explanations why derived key is also unspendable, but didn't find a good link for it yet upd: After some research (basically asking Vlad) I think this explanations don't needed and reason that derived key is unspendable is same that the reason original key is unspendable -- we publicly show the way we generated this pubkey |
There was a problem hiding this comment.
Looks good.
One suggestion is to put the logic for how we derive the key in the LazyLock's function definition. The derivation is fast and only happens once. We would still want a test that the output bytes equal what we expect them to be.
Also, after doing some digging, it seems like this change is indeed required. Ledger requires a wallet policy all the time, and so we need to prove that we know the derivation path. I'd still like to hear it from a Ledger engineer if possible (in a reasonable amount of time).
| LazyLock::new(|| XOnlyPublicKey::from_slice(&DERIVED_NUMS_X_COORDINATE).unwrap()); | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use bitcoin::bip32::{ChainCode, ChildNumber, DerivationPath, Fingerprint, Xpub}; | ||
| use secp256k1::{PublicKey, Secp256k1}; | ||
| use std::str::FromStr; | ||
|
|
||
| /// This test proves, that the DERIVED_NUMS_X_COORDINATE is correct, | ||
| /// and is derived from the NUMS_X_COORDINATE using the derivation path "0/0". | ||
| #[test] | ||
| fn test_derivation() { |
There was a problem hiding this comment.
One alternative is to define the UNSPENDABLE_TAPROOT_KEY using the same logic of this test.
|
@djordon if I understand correctly you suggesting to move derivation logic from test to I think this two options are +- equal and I don't prefer much one to another. But I see a small benefit from option I initially chose: we move derivation logic out of main code making it simpler and easier to read. I think in most cases when you are looking through the sbtc code you are not very interested how we choose the internal key, and when you interested in it, you will look at the test What benefits you think we will get moving derivation logic from tests to main code? |
Description
Closes: #1253
Changes
Testing Information
Checklist: