Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Audit Issues #72

Closed
14 of 16 tasks
Buttaa opened this issue Oct 11, 2021 · 9 comments
Closed
14 of 16 tasks

Pre Audit Issues #72

Buttaa opened this issue Oct 11, 2021 · 9 comments
Labels
bug Something isn't working priority - high

Comments

@Buttaa
Copy link
Contributor

Buttaa commented Oct 11, 2021

@Buttaa Buttaa added bug Something isn't working priority - high labels Oct 11, 2021
@Buttaa
Copy link
Contributor Author

Buttaa commented Oct 11, 2021

24 input boxes (while creating and re-typing) + remove copy button on mainnet

Same as: #57

App image starter linux

Same as: #59

@remyroy
Copy link
Member

remyroy commented Oct 25, 2021

Related Windows code signing/warning prompts issue can be found in #76

@remyroy
Copy link
Member

remyroy commented Oct 25, 2021

checksum file can be easily generated from a release asset with something like:

sha256sum WagyuKeyGen-0.8.0.exe > WagyuKeyGen-0.8.0.exe.sha256

We would just need to add the resulting file with the release assets.

@remyroy
Copy link
Member

remyroy commented Oct 25, 2021

Ideally, we would want to use a CI server to build our release and only have the CI server do all the packaging, signing and generating the checksum file.

@remyroy
Copy link
Member

remyroy commented Oct 26, 2021

Failed to write in directory should be fixed with #77

@remyroy
Copy link
Member

remyroy commented Oct 28, 2021

So far the AppImage target for Linux built on Ubuntu Desktop 20.04 works on:

  • Ubuntu Desktop 20.04 ✔
  • Debian 11.1 ✔
  • Linux Mint 20.2 ✔
  • Manjaro 21.1.6 ✔
  • Pop OS! 21.04 ✔ (Only started from the command line for some reason. Cannot double click on the file to start it. I might have missed something 🤔)
  • Fedora 34 Workstation ✔
  • MX Linux 21 ✔
  • archlinux-2021.10.01 ✔
  • EndeavourOS 2021.08.27 ✔

It fails on:

No warning prompt on any of these distro, but you need to make the file executable (+x) to run it which might be somewhat confusing for some. Documentation will have to mention that for sure.

@remyroy
Copy link
Member

remyroy commented Oct 28, 2021

Getting a working dev/bundle environment for Key Gen on Ubuntu Desktop 18.04 is very different than the instructions we currently have and it was a pain, but I managed to bundle there with Python 3.7. The resulting AppImage target does run on Tails 4.23 ✔.

I'll have to write those instructions down and make it clean so we can reproduce it.

@remyroy
Copy link
Member

remyroy commented Oct 29, 2021

I've updated the README to include instructions on how to setup a clean Ubuntu Desktop 18.04 machine to build Linux distribution releases.

@remyroy
Copy link
Member

remyroy commented Oct 29, 2021

Just tested to confirm that the bundled key gen works on Windows 8.1 ✔. But I found an issue which should be fixed with #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority - high
Projects
None yet
Development

No branches or pull requests

2 participants