You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wonderful work on this package!🎉 I can see that you put a lot of effort and detail into wrapping your function from Assignment B1 into a package - great job! A few comments:
It's always recommended to add devtools infront of install_github(""): devtools::install_github("")
When I run ?columnTopN::column_top_n to get a description of the function, the function title contained both the title and the description: Column Top n Given a data and a column, this function counts the number of observations for each factor of the column levels and returns the top n with the most observations. If n is equal to the number of levels, then returns the number of observation for each level. This because your title contains a dot at the end (it should be removed): "Return the top N most occurent observations of a dataframe column."
Running check() commands generated a warning: Undocumented arguments in documentation object 'column_top_n' 'col' ; Documented arguments not in \usage in documentation object 'column_top_n': 'column'.
objects cancer_test and test1 created in the test-column_top_n.R script are not cleaned up at the end of the script using rm().
I am not sure what the purpose is of the columnTopN.Rcheck folder - better to remove it.
Best,
Albina
The text was updated successfully, but these errors were encountered:
Hi Irem,
Wonderful work on this package!🎉 I can see that you put a lot of effort and detail into wrapping your function from Assignment B1 into a package - great job! A few comments:
devtools
infront ofinstall_github("")
:devtools::install_github("")
?columnTopN::column_top_n
to get a description of the function, the function title contained both the title and the description:Column Top n Given a data and a column, this function counts the number of observations for each factor of the column levels and returns the top n with the most observations. If n is equal to the number of levels, then returns the number of observation for each level.
This because your title contains a dot at the end (it should be removed): "Return the top N most occurent observations of a dataframe column."check()
commands generated a warning: Undocumented arguments in documentation object 'column_top_n' 'col' ; Documented arguments not in \usage in documentation object 'column_top_n': 'column'.cancer_test
andtest1
created in the test-column_top_n.R script are not cleaned up at the end of the script usingrm()
.Best,
Albina
The text was updated successfully, but these errors were encountered: