Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment B-2 Feedback #2

Open
albina23 opened this issue Nov 30, 2021 · 0 comments
Open

Assignment B-2 Feedback #2

albina23 opened this issue Nov 30, 2021 · 0 comments

Comments

@albina23
Copy link

Hi Irem,

Wonderful work on this package!🎉 I can see that you put a lot of effort and detail into wrapping your function from Assignment B1 into a package - great job! A few comments:

  • It's always recommended to add devtools infront of install_github(""): devtools::install_github("")
  • When I run ?columnTopN::column_top_n to get a description of the function, the function title contained both the title and the description: Column Top n Given a data and a column, this function counts the number of observations for each factor of the column levels and returns the top n with the most observations. If n is equal to the number of levels, then returns the number of observation for each level. This because your title contains a dot at the end (it should be removed): "Return the top N most occurent observations of a dataframe column."
  • Running check() commands generated a warning: Undocumented arguments in documentation object 'column_top_n' 'col' ; Documented arguments not in \usage in documentation object 'column_top_n': 'column'.
  • objects cancer_test and test1 created in the test-column_top_n.R script are not cleaned up at the end of the script using rm().
  • I am not sure what the purpose is of the columnTopN.Rcheck folder - better to remove it.

Best,
Albina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant